Change Details

As soon as the page issues code is shipped we should remove the code relating to instrumentation - it adds unnecessary bloat to our codebase and has a high maintenance cost. = Acceptance criteria [] Changes should be made in a feature branch called "page-issues-cleanup". Use `git review page-issues-cleanup` to post code there. [] Code should be removed in a single patchset, to make it easier to restore this in future if needed. [] All JS relating to instrumentation in Minerva is removed (no changes to ReadingDepth should be necessary) [] All PHP relating to config is removed [] Cleanup any production config [] there should be no flash of unstyled content for the new treatment. = Developer notes Code to remove includes: ** pageIssues.js ** [] Remove formatPageIssuesSeverity [] abTest [] References to pageIssuesLogger removed [] isLoggingRequired removed [] removed all pageIssuesLogger.log calls ** pageIssuesLogger.js ** [] Removed in full **PageIssuesOverlay** [] PageIssuesOverlay no longer takes a PageIssuesLogger [] PageIssuesOverlay.prototype.events, log, onEditLink, onInternalLink, onRedLinkClick, onExit code can be removed. [] issuesSeverity and sectionNumbers no longer needs to be sent as part of modalClose event [] parseSeverity and issueSummaryToSeverity helpers removed = Sign off step [] Make sure there is a task open to merge the feature branch to master.

As soon as the page issues code is shipped we should remove the code relating to instrumentation - it adds unnecessary bloat to our codebase and has a high maintenance cost. = Acceptance criteria [x] Changes should be made in a feature branch called "page-issues-cleanup". Use `git review page-issues-cleanup` to post code there. [x] Code should be removed in a single patchset, to make it easier to restore this in future if needed. [x] All JS relating to instrumentation in Minerva is removed (no changes to ReadingDepth should be necessary) [x] All PHP relating to config is removed [x] Cleanup any production config [x] there should be no flash of unstyled content for the new treatment. = Developer notes Code to remove includes: ** pageIssues.js ** [x] Remove formatPageIssuesSeverity [x] abTest [x] References to pageIssuesLogger removed [x] isLoggingRequired removed [x] removed all pageIssuesLogger.log calls ** pageIssuesLogger.js ** [x] Removed in full **PageIssuesOverlay** [x] PageIssuesOverlay no longer takes a PageIssuesLogger [x] PageIssuesOverlay.prototype.events, log, onEditLink, onInternalLink, onRedLinkClick, onExit code can be removed. [x] issuesSeverity and sectionNumbers no longer needs to be sent as part of modalClose event [x] parseSeverity and issueSummaryToSeverity helpers removed = Sign off step [x] Make sure there is a task open to merge the feature branch to master.

As soon as the page issues code is shipped we should remove the code relating to instrumentation - it adds unnecessary bloat to our codebase and has a high maintenance cost. = Acceptance criteria [x] Changes should be made in a feature branch called "page-issues-cleanup". Use `git review page-issues-cleanup` to post code there. [x] Code should be removed in a single patchset, to make it easier to restore this in future if needed. [x] All JS relating to instrumentation in Minerva is removed (no changes to ReadingDepth should be necessary) [x] All PHP relating to config is removed [x] Cleanup any production config [x] there should be no flash of unstyled content for the new treatment. = Developer notes Code to remove includes: ** pageIssues.js ** [x] Remove formatPageIssuesSeverity [x] abTest [x] References to pageIssuesLogger removed [x] isLoggingRequired removed [x] removed all pageIssuesLogger.log calls ** pageIssuesLogger.js ** [x] Removed in full **PageIssuesOverlay** [x] PageIssuesOverlay no longer takes a PageIssuesLogger [x] PageIssuesOverlay.prototype.events, log, onEditLink, onInternalLink, onRedLinkClick, onExit code can be removed. [x] issuesSeverity and sectionNumbers no longer needs to be sent as part of modalClose event [x] parseSeverity and issueSummaryToSeverity helpers removed = Sign off step [x] Make sure there is a task open to merge the feature branch to master.