Change Details

#### Description This extension checks to see if a logged in editor qualifies for access to [[ https://wikipedialibrary.wmflabs.org/ | The Wikipedia Library ]] by checking their account age and global edit count. The first time they become eligible, it sends them a notification about it. #### Preview environment https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page This has been deployed to beta cluster, but is currently disabled while we work through issues we discovered upon deployment. #### Which code to review https://gerrit.wikimedia.org/r/mediawiki/extensions/TheWikipediaLibrary We're currently working on adding tests (T271919) as well as reworking the way the extension interacts with global preferences (T256297). #### Performance assessment Please initiate the performance assessment by answering the below: - What work has been done to ensure the best possible performance of the feature? - None, will update with details when we have done so. - What are likely to be the weak areas (e.g. bottlenecks) of the code in terms of performance? - This will be adding db queries to page loads, and that's where I'd look. - Are there potential optimisations that haven't been performed yet? - Yes, we're going to think about the best place to hook in our eligibility checks, and take a look at our guard clauses to minimize execution. - Please list which performance measurements are in place for the feature and/or what you've measured ad-hoc so far. If you are unsure what to measure, ask the Performance Team for advice: [[ mailto:performance-team@wikimedia.org | performance-team@wikimedia.org ]]. - None, will update with details when we have done so and will query the performance team as recommended should we get lost.

#### Description This extension checks to see if a logged in editor qualifies for access to [[ https://wikipedialibrary.wmflabs.org/ | The Wikipedia Library ]] by checking their account age and global edit count. The first time they become eligible, it sends them a notification about it. #### Preview environment https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page This has been deployed to beta cluster. It is currently configured to notify editors when they reach 100 edits with an account that is at least one day old. #### Which code to review https://gerrit.wikimedia.org/r/mediawiki/extensions/TheWikipediaLibrary #### Performance assessment Please initiate the performance assessment by answering the below: - What work has been done to ensure the best possible performance of the feature? - None, will update with details when we have done so. - What are likely to be the weak areas (e.g. bottlenecks) of the code in terms of performance? - We're doing an extra read + write to global preferences on save in a pretty common case. This was originally sending duplicate notifications on beta do to silent failures to read/write global prefs, and this workaround ensures that we only send if we're **really** sure that globalprefs is working correctly. - Are there potential optimisations that haven't been performed yet? - We could potentially do a more efficient globalprefs check if we were ever able to reproduce the duplicate notifications outside of beta - Please list which performance measurements are in place for the feature and/or what you've measured ad-hoc so far. If you are unsure what to measure, ask the Performance Team for advice: [[ mailto:performance-team@wikimedia.org | performance-team@wikimedia.org ]]. - None, will query the performance team as recommended.

#### Description This extension checks to see if a logged in editor qualifies for access to [[ https://wikipedialibrary.wmflabs.org/ | The Wikipedia Library ]] by checking their account age and global edit count. The first time they become eligible, it sends them a notification about it. #### Preview environment https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page This has been deployed to beta cluster,. buIt is currently disabled while we work through issues we discovered upon deploymentconfigured to notify editors when they reach 100 edits with an account that is at least one day old. #### Which code to review https://gerrit.wikimedia.org/r/mediawiki/extensions/TheWikipediaLibrary We're currently working on adding tests (T271919) as well as reworking the way the extension interacts with global preferences (T256297). #### Performance assessment Please initiate the performance assessment by answering the below: - What work has been done to ensure the best possible performance of the feature? - None, will update with details when we have done so. - What are likely to be the weak areas (e.g. bottlenecks) of the code in terms of performance? - This will be adding db queries to page loadWe're doing an extra read + write to global preferences on save in a pretty common case. This was originally sending duplicate notifications on beta do to silent failures to read/write global prefs, and that's where I'd lookis workaround ensures that we only send if we're **really** sure that globalprefs is working correctly. - Are there potential optimisations that haven't been performed yet? - Yes, we're going to think about the best place to hook in our eligibility checks, and take a look at our guard clauses to minimize execution.We could potentially do a more efficient globalprefs check if we were ever able to reproduce the duplicate notifications outside of beta - Please list which performance measurements are in place for the feature and/or what you've measured ad-hoc so far. If you are unsure what to measure, ask the Performance Team for advice: [[ mailto:performance-team@wikimedia.org | performance-team@wikimedia.org ]]. - None, will update with details when we have done so and will query the performance team as recommended should we get lost.