Change Details

EmailNotification: inject singleton services as DI [] $config = RequestContext::getMain()->getConfig(); [] JobQueueGroup::singleton()->lazyPush( Risks: min) [] UserOptionsLookup should be injected https://gerrit.wikimedia.org/r/c/mediawiki/core/+/597404/1/includes/mail/EmailNotification.php#272 [] A LoggerInstance should be injected https://gerrit.wikimedia.org/r/c/mediawiki/core/+/597404/1/includes/mail/EmailNotification.php#314 [] Should inject an ITextFormatter too https://gerrit.wikimedia.org/r/c/mediawiki/core/+/597404/1/includes/mail/EmailNotification.php#361 Injecting global variables https://gerrit.wikimedia.org/r/c/mediawiki/core/+/597404/1/includes/mail/EmailNotification.php#226 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/597404/1/includes/mail/EmailNotification.php#141 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/597404/1/includes/mail/EmailNotification.php#307 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/597404/1/includes/mail/EmailNotification.php#346 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/597404/1/includes/mail/EmailNotification.php#463 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/597404/1/includes/mail/EmailNotification.php#480 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/597404/1/includes/mail/EmailNotification.php#497