Change Details

{icon chevron-left} {T205029} || NOTYETCREATED {icon chevron-right} This is a list of potential deprecated code to drop. Not all of it will be dropped before 1.34 (and we'll move entries to a parallel ticket for 1.35). Found by manually looking for hard deprecations; soft-deprecated code isn't listed here (yet?). [ ] From 1.20 [x] `Linker` – calling `Linker::link()` with `$query` as a string rather than an array - Do {T223010} instead [ ] `OutputPage` – calling `::wrapWikiMsg()` with an options parameter - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/509591 [ ] `SkinTemplate` – Calling `::outputPage` with a specified context [hard-deprecated in 1.25] [ ] Search: https://codesearch.wmflabs.org/search/?q=outputPage%5C(&i=nope&files=&repos= (???) [ ] From 1.23 [ ] `SpecialPage::getTitle()` [] Usages in extensions T223005 [ ] From 1.24 [ ] `OutputPage` – Calling `::addScriptFile` with a path pointed at `/w/skins/common` or similar malformed request [ ] Search: https://codesearch.wmflabs.org/search/?q=addScriptFile&i=nope&files=&repos= (???) [ ] From 1.25 [ ] A whole lot of stuff in the Action API [x] Use of the `UtfNormal` class [x] `WikiPage – Calling ::prepareContentForEdit` with a `revisionid` rather than a `Revision` object - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/511761 [x] Search: https://codesearch.wmflabs.org/search/?q=-%3EprepareContentForEdit%5C(&i=nope&files=&repos= [ ] `ApiBase` - `getExamples()` [ ] From 1.26 [X] `ApiPageSet::getInvalidTitles()`- per https://codesearch.wmflabs.org/search/?q=getInvalidTitles%5C(&i=nope&files=&repos= [X] Constructing a `Block` object with multiple arguments rather than an "options" array - per https://codesearch.wmflabs.org/search/?q=new%20Block%5C(&i=nope&files=&repos= [ ] The `UserRights` hook [ ] From 1.27 [ ] `AuthManager` migration stuff [ ] `wfSetupSession` and `wfResetSessionID` [ ] The `ChangePasswordForm` hook [ ] The `UserLoadFromSession` hook [ ] Calling `User::createNew()` with any of the params `password`, `newpassword`, `newpass_time`, or `password_expires` [ ] Writing to `$_SESSION` [ ] Specification of `$wgExternalDiffEngine` as `wikidiff` or `wikidiff3` [ ] From 1.28 [ ] The `APIEditBeforeSave` hook [ ] Linking things [ ] The `LinkBegin` and `LinkEnd` hooks [ ] The `DummyLinker` class [ ] `Interwiki – ::isValidInterwiki()`, `::fetch()`, `::invalidateCache()`, `::getAllPrefixes()` [ ] The `UploadVerification` hook [ ] `UploadBase/UploadFromChunks ::stashFile()`, `::stashFileGetKey()` and `::stashSession()` [x] `Language` [x] `initEncoding()`, `recodeForEdit()`, and `recodeInput()` - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/507221 [ ] From 1.29 [ ] A bunch of stuff in the Action API [ ] The UsageException (outside of an ApiUsageException) [X] `DeferredUpdates::setImmediateMode()` [ ] `EditPage::submit()` [ ] `Message::getFormat()` [ ] `Article::doEditContent()` – T155696 [ ] Having no `manifest_version` set in `extension.json` [ ] `EmailUser` hook returning a raw HTML string as an error [X] `User` [x] `::getGroupPage()` https://gerrit.wikimedia.org/r/c/mediawiki/core/+/506974 [x] `::makeGroupLinkHTML()` https://gerrit.wikimedia.org/r/c/mediawiki/core/+/506974 [X] `::makeGroupLinkWiki()` https://gerrit.wikimedia.org/r/c/mediawiki/core/+/507198 [ ] From 1.30 [ ] `BufferingStatsdDataFactory::getBuffer()` [X] `Title::escapeFragmentForURL()` [X] `ParserOptions::legacyOptions()` - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/495406 [ ] `Special:EmailUser::getTarget()` or `::validateTarget()` without specifying the sending user [ ] `User` – Setting IP addresses in the keys of `$wgProxyList`

{icon chevron-left} {T205029} || NOTYETCREATED {icon chevron-right} This is a list of potential deprecated code to drop. Not all of it will be dropped before 1.34 (and we'll move entries to a parallel ticket for 1.35). Found by manually looking for hard deprecations; soft-deprecated code isn't listed here (yet?). [ ] From 1.20 [x] `Linker` – calling `Linker::link()` with `$query` as a string rather than an array - Do {T223010} instead [ ] `OutputPage` – calling `::wrapWikiMsg()` with an options parameter - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/509591 [ ] `SkinTemplate` – Calling `::outputPage` with a specified context [hard-deprecated in 1.25] [ ] Search: https://codesearch.wmflabs.org/search/?q=outputPage%5C(&i=nope&files=&repos= (???) [ ] From 1.23 [ ] `SpecialPage::getTitle()` [x] Usages in extensions T223005 [ ] From 1.24 [ ] `OutputPage` – Calling `::addScriptFile` with a path pointed at `/w/skins/common` or similar malformed request [ ] Search: https://codesearch.wmflabs.org/search/?q=addScriptFile&i=nope&files=&repos= (???) [ ] From 1.25 [ ] A whole lot of stuff in the Action API [x] Use of the `UtfNormal` class [x] `WikiPage – Calling ::prepareContentForEdit` with a `revisionid` rather than a `Revision` object - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/511761 [x] Search: https://codesearch.wmflabs.org/search/?q=-%3EprepareContentForEdit%5C(&i=nope&files=&repos= [ ] `ApiBase` - `getExamples()` [ ] From 1.26 [X] `ApiPageSet::getInvalidTitles()`- per https://codesearch.wmflabs.org/search/?q=getInvalidTitles%5C(&i=nope&files=&repos= [X] Constructing a `Block` object with multiple arguments rather than an "options" array - per https://codesearch.wmflabs.org/search/?q=new%20Block%5C(&i=nope&files=&repos= [ ] The `UserRights` hook [ ] From 1.27 [ ] `AuthManager` migration stuff [ ] `wfSetupSession` and `wfResetSessionID` [ ] The `ChangePasswordForm` hook [ ] The `UserLoadFromSession` hook [ ] Calling `User::createNew()` with any of the params `password`, `newpassword`, `newpass_time`, or `password_expires` [ ] Writing to `$_SESSION` [ ] Specification of `$wgExternalDiffEngine` as `wikidiff` or `wikidiff3` [ ] From 1.28 [ ] The `APIEditBeforeSave` hook [ ] Linking things [ ] The `LinkBegin` and `LinkEnd` hooks [ ] The `DummyLinker` class [ ] `Interwiki – ::isValidInterwiki()`, `::fetch()`, `::invalidateCache()`, `::getAllPrefixes()` [ ] The `UploadVerification` hook [ ] `UploadBase/UploadFromChunks ::stashFile()`, `::stashFileGetKey()` and `::stashSession()` [x] `Language` [x] `initEncoding()`, `recodeForEdit()`, and `recodeInput()` - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/507221 [ ] From 1.29 [ ] A bunch of stuff in the Action API [ ] The UsageException (outside of an ApiUsageException) [X] `DeferredUpdates::setImmediateMode()` [ ] `EditPage::submit()` [ ] `Message::getFormat()` [ ] `Article::doEditContent()` – T155696 [ ] Having no `manifest_version` set in `extension.json` [ ] `EmailUser` hook returning a raw HTML string as an error [X] `User` [x] `::getGroupPage()` https://gerrit.wikimedia.org/r/c/mediawiki/core/+/506974 [x] `::makeGroupLinkHTML()` https://gerrit.wikimedia.org/r/c/mediawiki/core/+/506974 [X] `::makeGroupLinkWiki()` https://gerrit.wikimedia.org/r/c/mediawiki/core/+/507198 [ ] From 1.30 [ ] `BufferingStatsdDataFactory::getBuffer()` [X] `Title::escapeFragmentForURL()` [X] `ParserOptions::legacyOptions()` - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/495406 [ ] `Special:EmailUser::getTarget()` or `::validateTarget()` without specifying the sending user [ ] `User` – Setting IP addresses in the keys of `$wgProxyList`

{icon chevron-left} {T205029} || NOTYETCREATED {icon chevron-right} This is a list of potential deprecated code to drop. Not all of it will be dropped before 1.34 (and we'll move entries to a parallel ticket for 1.35). Found by manually looking for hard deprecations; soft-deprecated code isn't listed here (yet?). [ ] From 1.20 [x] `Linker` – calling `Linker::link()` with `$query` as a string rather than an array - Do {T223010} instead [ ] `OutputPage` – calling `::wrapWikiMsg()` with an options parameter - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/509591 [ ] `SkinTemplate` – Calling `::outputPage` with a specified context [hard-deprecated in 1.25] [ ] Search: https://codesearch.wmflabs.org/search/?q=outputPage%5C(&i=nope&files=&repos= (???) [ ] From 1.23 [ ] `SpecialPage::getTitle()` [x] Usages in extensions T223005 [ ] From 1.24 [ ] `OutputPage` – Calling `::addScriptFile` with a path pointed at `/w/skins/common` or similar malformed request [ ] Search: https://codesearch.wmflabs.org/search/?q=addScriptFile&i=nope&files=&repos= (???) [ ] From 1.25 [ ] A whole lot of stuff in the Action API [x] Use of the `UtfNormal` class [x] `WikiPage – Calling ::prepareContentForEdit` with a `revisionid` rather than a `Revision` object - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/511761 [x] Search: https://codesearch.wmflabs.org/search/?q=-%3EprepareContentForEdit%5C(&i=nope&files=&repos= [ ] `ApiBase` - `getExamples()` [ ] From 1.26 [X] `ApiPageSet::getInvalidTitles()`- per https://codesearch.wmflabs.org/search/?q=getInvalidTitles%5C(&i=nope&files=&repos= [X] Constructing a `Block` object with multiple arguments rather than an "options" array - per https://codesearch.wmflabs.org/search/?q=new%20Block%5C(&i=nope&files=&repos= [ ] The `UserRights` hook [ ] From 1.27 [ ] `AuthManager` migration stuff [ ] `wfSetupSession` and `wfResetSessionID` [ ] The `ChangePasswordForm` hook [ ] The `UserLoadFromSession` hook [ ] Calling `User::createNew()` with any of the params `password`, `newpassword`, `newpass_time`, or `password_expires` [ ] Writing to `$_SESSION` [ ] Specification of `$wgExternalDiffEngine` as `wikidiff` or `wikidiff3` [ ] From 1.28 [ ] The `APIEditBeforeSave` hook [ ] Linking things [ ] The `LinkBegin` and `LinkEnd` hooks [ ] The `DummyLinker` class [ ] `Interwiki – ::isValidInterwiki()`, `::fetch()`, `::invalidateCache()`, `::getAllPrefixes()` [ ] The `UploadVerification` hook [ ] `UploadBase/UploadFromChunks ::stashFile()`, `::stashFileGetKey()` and `::stashSession()` [x] `Language` [x] `initEncoding()`, `recodeForEdit()`, and `recodeInput()` - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/507221 [ ] From 1.29 [ ] A bunch of stuff in the Action API [ ] The UsageException (outside of an ApiUsageException) [X] `DeferredUpdates::setImmediateMode()` [ ] `EditPage::submit()` [ ] `Message::getFormat()` [ ] `Article::doEditContent()` – T155696 [ ] Having no `manifest_version` set in `extension.json` [ ] `EmailUser` hook returning a raw HTML string as an error [X] `User` [x] `::getGroupPage()` https://gerrit.wikimedia.org/r/c/mediawiki/core/+/506974 [x] `::makeGroupLinkHTML()` https://gerrit.wikimedia.org/r/c/mediawiki/core/+/506974 [X] `::makeGroupLinkWiki()` https://gerrit.wikimedia.org/r/c/mediawiki/core/+/507198 [ ] From 1.30 [ ] `BufferingStatsdDataFactory::getBuffer()` [X] `Title::escapeFragmentForURL()` [X] `ParserOptions::legacyOptions()` - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/495406 [ ] `Special:EmailUser::getTarget()` or `::validateTarget()` without specifying the sending user [ ] `User` – Setting IP addresses in the keys of `$wgProxyList`