Change Details

Client values inbound in X-analytics header are reflected in outbound X-Analytics on varnish We shouldn't blindly copy it, or the client will have a chance to duplicate/suppress fields they shouldn't be able to. So we'll need to parse it in VCL and only copy through the known-good values clients are allowed to set. Thus far is only two pageview and preview. See: https://wikitech.wikimedia.org/wiki/X-Analytics

Client values (pageview and preview) inbound in X-analytics header are reflected in outbound X-Analytics on varnish We shouldn't blindly copy it, or the client will have a chance to duplicate/suppress fields they shouldn't be able to. So we'll need to parse it in VCL and only copy through the known-good values clients are allowed to set. Thus far is only two pageview and preview. See: https://wikitech.wikimedia.org/wiki/X-Analytics

Client values (pageview and preview) inbound in X-analytics header are reflected in outbound X-Analytics on varnish We shouldn't blindly copy it, or the client will have a chance to duplicate/suppress fields they shouldn't be able to. So we'll need to parse it in VCL and only copy through the known-good values clients are allowed to set. Thus far is only two pageview and preview. See: https://wikitech.wikimedia.org/wiki/X-Analytics