Change Details

=== Background Currently, QuickSurveys adds the `ext.quicksurveys.init` RL module to the output if the page exists, regardless of whether there are any surveys defined and that are enabled. This causes two issues, one minor and one major in the case of the Wikipedias: 1. There's is a performance penalty as the module (and its `ext.quicksurveys.lib` dependency) is loaded for every mainspace page that exists # If you have responses cached at the edge and disable the QuickSurveys extension, then RL will trigger an error for every mainspace pageview (for pages that exist) as the `ext.quicksurveys.init` module no longer exists but is still referenced === Testing Environment for QA None. However, see T209882#4868432 for an example of 2 that occurred in the wild. === Acceptance Criteria [] When there are no surveys defined, then the `ext.quicksurveys.init` RL module is not added to the output (or the code it loads is minimised to a conditional client side check) [] When there are no surveys enabled, then the `ext.quicksurveys.init` RL module is not added to the output (or the code it loads is minimised to a conditional client side check) [] This behaviour is documented ** Including a note about not immediately disabling the extension after running a survey === Notes @Krinkle's suggested approach: T213459#4871107

=== Background Currently, QuickSurveys adds the `ext.quicksurveys.init` RL module to the output if the page exists, regardless of whether there are any surveys defined and that are enabled. This causes two issues, one minor and one major in the case of the Wikipedias: 1. There's is a performance penalty as the module (and its `ext.quicksurveys.lib` dependency) is loaded for every mainspace page that exists # If you have responses cached at the edge and disable the QuickSurveys extension, then RL will trigger an error for every mainspace pageview (for pages that exist) as the `ext.quicksurveys.init` module no longer exists but is still referenced === Performance ext.quicksurveys.lib is 2.4kb and ext.quicksurveys.init 641 bytes. === Testing Environment for QA None. However, see T209882#4868432 for an example of 2 that occurred in the wild. === Acceptance Criteria [] When there are no surveys defined, then the `ext.quicksurveys.init` RL module is not added to the output (or the code it loads is minimised to a conditional client side check) [] When there are no surveys enabled, then the `ext.quicksurveys.init` RL module is not added to the output (or the code it loads is minimised to a conditional client side check) [] This behaviour is documented ** Including a note about not immediately disabling the extension after running a survey === Notes @Krinkle's suggested approach: T213459#4871107

=== Background Currently, QuickSurveys adds the `ext.quicksurveys.init` RL module to the output if the page exists, regardless of whether there are any surveys defined and that are enabled. This causes two issues, one minor and one major in the case of the Wikipedias: 1. There's is a performance penalty as the module (and its `ext.quicksurveys.lib` dependency) is loaded for every mainspace page that exists # If you have responses cached at the edge and disable the QuickSurveys extension, then RL will trigger an error for every mainspace pageview (for pages that exist) as the `ext.quicksurveys.init` module no longer exists but is still referenced === Performance ext.quicksurveys.lib is 2.4kb and ext.quicksurveys.init 641 bytes. === Testing Environment for QA None. However, see T209882#4868432 for an example of 2 that occurred in the wild. === Acceptance Criteria [] When there are no surveys defined, then the `ext.quicksurveys.init` RL module is not added to the output (or the code it loads is minimised to a conditional client side check) [] When there are no surveys enabled, then the `ext.quicksurveys.init` RL module is not added to the output (or the code it loads is minimised to a conditional client side check) [] This behaviour is documented ** Including a note about not immediately disabling the extension after running a survey === Notes @Krinkle's suggested approach: T213459#4871107