Change Details

26570726f6475636520796f757220627567207573696e67206120726563656e742076657273696f6e206f662074686520736f6674776172652c20746f2068652077696b6920636f6e74656e74206c616e67756167652e0a0a5468616e6b20796f752e0a546167730a436865636b557365720ad70a436f6e6e65637465642d4f70656e2d48657269746167652d42617463682d75706c6f61647320285241c42d4b4d425f315f323031372d3032290ad70a54616d696c2d53697465730ad70a47616d6570726573730ad70a48617368746167730ad70a4a4144450ad70a4b6172746f456469746f720ad70a4c616e67756167652d323031382d4170722d4a756e650ad70a4e65772d456469746f722d457870657269656e6365730ad70a4d61696c0ad70a5443422d5465616d0ad70a53756273637269626572730a4465736372697074696f6e20507265766965770a436f6e74656e77a6f6e652073657474696e6720696e20796f75722070726f66696c652c20636c69636b20746f207265636f6e63696c652e

Doing a `check experimental` on WikibaseLexeme triggers quibble-composer-mysql-php70-docker which fails a couple PHPUnit tests. Debug logs: P7271 and P7272 ``` 1) Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest::testAddedStatementsWithLexmesAsTargetDisplayLemma Hamcrest\AssertionError: Expected: is valid html piece having child (with tag name "ins" and having child (with tag name "a" and having text contents "foo")) but: valid html piece having no children (with tag name "ins" and having child (with tag name "a" and having text contents "foo")) Actual html: <tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">property / <a title="Property:P1" href="/index.php/Property:P1">P1</a></td></tr><tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span><a title="Lexeme:L1" href="/index.php/Lexeme:L1">L1</a> <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span></span></ins></div></td></tr><tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">property / <a title="Property:P1" href="/index.php/Property:P1">P1</a>: <a title="Lexeme:L1" href="/index.php/Lexeme:L1">L1</a> <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span> / rank</td></tr><tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span>Normal rank</span></ins></div></td></tr> gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:115 gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:52 gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest.php:28 gtests/phpunit/HamcrestPHPUnitIntegration.php:31 gextensions/WikibaseLexeme/tests/phpunit/mediawiki/Diff/LexemeDiffVisualizerIntegrationTest.php:109 gtests/phpunit/MediaWikiTestCase.php:469 gmaintenance/doMaintenance.php:94 ``` ``` 2) Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest::testAddedStatementsOnFormsTargettingFormsAreDisplayedAsLinks Hamcrest\AssertionError: Expected: is valid html piece having child (with tag name "ins" and having child (with tag name "a" and having text contents "baz")) but: valid html piece having no children (with tag name "ins" and having child (with tag name "a" and having text contents "baz")) Actual html: <tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">Form / property / <a title="Property:P1" href="/index.php/Property:P1">P1</a></td></tr><tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span><a title="Lexeme:L1" href="/index.php/Lexeme:L1">L1-F1</a> <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span></span></ins></div></td></tr><tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">Form / property / <a title="Property:P1" href="/index.php/Property:P1">P1</a>: <a title="Lexeme:L1" href="/index.php/Lexeme:L1">L1-F1</a> <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span> / rank</td></tr><tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span>Normal rank</span></ins></div></td></tr> gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:115 gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:52 gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest.php:28 gtests/phpunit/HamcrestPHPUnitIntegration.php:31 gextensions/WikibaseLexeme/tests/phpunit/mediawiki/Diff/LexemeDiffVisualizerIntegrationTest.php:440 gtests/phpunit/MediaWikiTestCase.php:469 gmaintenance/doMaintenance.php:94 ``` Dummy change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/435980 Failed build: https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php70-docker/2297/ Note in both case they show: `The value's type "wikibase-entityid" does not match property's type "string".`