Change Details

`Special:MWOAuth/identify` and `rest.php/oauth2/resource/profile` are mechanisms to identify a user in OAuth1 and OAuth2, respectively. For OAuth2, the corresponding class for the REST API endpoint is: `Resource`. Integration tests would be written to cover the special page case for OAuth1 and the REST Handler case for OAuth2. In addition, the backend logic that interacts with the DB would need to be tested appropriately (using unit tests for self-contained logic). We already have a way to write integration tests for REST API handlers in MediaWiki using the `HandlerTestTrait` trait. Some good examples can be found at: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/0aa7ce021b7904ed4f63f941f307f0143a32d0bf/tests/phpunit/integration/includes/Rest/Handler. And for special pages, use `SpecialPageTestBase`. ## Impact [ ] Increase coverage of the REST Handler classes: https://doc.wikimedia.org/cover-extensions/OAuth/src/Rest/Handler/Resource.php.html [ ] Increase in code coverage: https://doc.wikimedia.org/cover-extensions/OAuth/src/Backend/ConsumerAcceptance.php.html

`Special:MWOAuth/identify` and `rest.php/oauth2/resource/profile` are mechanisms to identify a user in OAuth1 and OAuth2, respectively. For OAuth2, the corresponding class for the REST API endpoint is: `Resource`. Integration tests would be written to cover the special page case for OAuth1 and the REST Handler case for OAuth2. In addition, the backend logic that interacts with the DB would need to be tested appropriately (using unit tests for self-contained logic). We already have a way to write integration tests for REST API handlers in MediaWiki using the `HandlerTestTrait` trait. Some good examples can be found at: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/0aa7ce021b7904ed4f63f941f307f0143a32d0bf/tests/phpunit/integration/includes/Rest/Handler. And for special pages, use `SpecialPageTestBase`. ## Impact [ ] Increase coverage of the REST Handler classes: https://doc.wikimedia.org/cover-extensions/OAuth/src/Rest/Handler/Resource.php.html [ ] Increase in code coverage: https://doc.wikimedia.org/cover-extensions/OAuth/src/Backend/ConsumerAcceptance.php.html (T416761)

`Special:MWOAuth/identify` and `rest.php/oauth2/resource/profile` are mechanisms to identify a user in OAuth1 and OAuth2, respectively. For OAuth2, the corresponding class for the REST API endpoint is: `Resource`. Integration tests would be written to cover the special page case for OAuth1 and the REST Handler case for OAuth2. In addition, the backend logic that interacts with the DB would need to be tested appropriately (using unit tests for self-contained logic). We already have a way to write integration tests for REST API handlers in MediaWiki using the `HandlerTestTrait` trait. Some good examples can be found at: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/0aa7ce021b7904ed4f63f941f307f0143a32d0bf/tests/phpunit/integration/includes/Rest/Handler. And for special pages, use `SpecialPageTestBase`. ## Impact [ ] Increase coverage of the REST Handler classes: https://doc.wikimedia.org/cover-extensions/OAuth/src/Rest/Handler/Resource.php.html [ ] Increase in code coverage: https://doc.wikimedia.org/cover-extensions/OAuth/src/Backend/ConsumerAcceptance.php.html (T416761)