Change Details

Aleksey wrote: > Statement ID should be mandatory on domain model level. To achieve this we need to have method addStatement() on an Entity that will generate correct ID (we cannot do it in Statement constructor because we need an entity ID so we will adhere to the current contract <Q1$UUID>) Current changes complicated by this: * need to [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/460891/2/src/ChangeOp/ChangeOpSenseAdd.php | update statement GUIDs after **sense sub entity** is associated with a lexeme ]] (currently T201605) * need to [[ https://github.com/wikimedia/mediawiki-extensions-WikibaseLexeme/blob/master/src/ChangeOp/ChangeOpFormAdd.php#L59 | update statement GUIDs after **form sub entity** is associated with a lexeme ]] (previously T201389)

Aleksey wrote: > Statement ID should be mandatory on domain model level. To achieve this we need to have method addStatement() on an Entity that will generate correct ID (we cannot do it in Statement constructor because we need an entity ID so we will adhere to the current contract <Q1$UUID>) Current changes complicated by this: * need to [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/460891/2/src/ChangeOp/ChangeOpSenseAdd.php | update statement GUIDs after **sense sub entity** is associated with a lexeme ]] (T201605) * need to [[ https://github.com/wikimedia/mediawiki-extensions-WikibaseLexeme/blob/master/src/ChangeOp/ChangeOpFormAdd.php#L59 | update statement GUIDs after **form sub entity** is associated with a lexeme ]] (T201389, T194732)

Aleksey wrote: > Statement ID should be mandatory on domain model level. To achieve this we need to have method addStatement() on an Entity that will generate correct ID (we cannot do it in Statement constructor because we need an entity ID so we will adhere to the current contract <Q1$UUID>) Current changes complicated by this: * need to [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/460891/2/src/ChangeOp/ChangeOpSenseAdd.php | update statement GUIDs after **sense sub entity** is associated with a lexeme ]] (currently T201605) * need to [[ https://github.com/wikimedia/mediawiki-extensions-WikibaseLexeme/blob/master/src/ChangeOp/ChangeOpFormAdd.php#L59 | update statement GUIDs after **form sub entity** is associated with a lexeme ]] (previously T201389T201389, T194732)