Change Details

Two edits to two translation units were collated in a single edit to the translation page: <https://meta.wikimedia.org/w/index.php?title=Special:Contributions/Nemo_bis&dir=prev&offset=20130308105148&limit=3&target=Nemo+bis> Is this intentional? If yes we should document how the edit summary is chosen, so that the user knows what to write. Cf.: >>! In T53731#2151432, Glaisher wrote: > In `SpecialPageTranslation::markForTranslation()`, TranslateRenderJobs for updating the translation pages are pushed to the queue first and then MessageUpdateJobs are pushed to the queue to update the translation units. These jobs can be run in any order but usually it's sequentially (I think). However, TranslateRenderJob depends on the translation units to be updated through MessageUpdateJobs before it is run because TranslateRenderJob retrieves the content for the translation page edit through the updates from that job. > > To confirm this and to make it easier to debug, I locally hacked markForTranslation() to make the jobs be `run()` immediately instead of pushing them to the queue. If the order is changed so that `getTranslationUnitJobs()` is run before `getRenderJobs()`, this bug cannot be reproduced at all but is present if it's in the current order. Note that the /en page would be updated but this is because of the edits to the unit pages which trigger the hook making the TranslateRenderJob be run repeatedly on that page. We should probably stop doing that. -------------------------- **Version**: unspecified **Severity**: minor **See Also**: https://bugzilla.wikimedia.org/show_bug.cgi?id=46716

NOTE: For a summary on related issues, patches and upgrade avenues, see {T48716}. Two edits to two translation units were collated in a single edit to the translation page: <https://meta.wikimedia.org/w/index.php?title=Special:Contributions/Nemo_bis&dir=prev&offset=20130308105148&limit=3&target=Nemo+bis> Is this intentional? If yes we should document how the edit summary is chosen, so that the user knows what to write. Cf.: >>! In T53731#2151432, Glaisher wrote: > In `SpecialPageTranslation::markForTranslation()`, TranslateRenderJobs for updating the translation pages are pushed to the queue first and then MessageUpdateJobs are pushed to the queue to update the translation units. These jobs can be run in any order but usually it's sequentially (I think). However, TranslateRenderJob depends on the translation units to be updated through MessageUpdateJobs before it is run because TranslateRenderJob retrieves the content for the translation page edit through the updates from that job. > > To confirm this and to make it easier to debug, I locally hacked markForTranslation() to make the jobs be `run()` immediately instead of pushing them to the queue. If the order is changed so that `getTranslationUnitJobs()` is run before `getRenderJobs()`, this bug cannot be reproduced at all but is present if it's in the current order. Note that the /en page would be updated but this is because of the edits to the unit pages which trigger the hook making the TranslateRenderJob be run repeatedly on that page. We should probably stop doing that. -------------------------- **Version**: unspecified **Severity**: minor **See Also**: https://bugzilla.wikimedia.org/show_bug.cgi?id=46716

NOTE: For a summary on related issues, patches and upgrade avenues, see {T48716}. Two edits to two translation units were collated in a single edit to the translation page: <https://meta.wikimedia.org/w/index.php?title=Special:Contributions/Nemo_bis&dir=prev&offset=20130308105148&limit=3&target=Nemo+bis> Is this intentional? If yes we should document how the edit summary is chosen, so that the user knows what to write. Cf.: >>! In T53731#2151432, Glaisher wrote: > In `SpecialPageTranslation::markForTranslation()`, TranslateRenderJobs for updating the translation pages are pushed to the queue first and then MessageUpdateJobs are pushed to the queue to update the translation units. These jobs can be run in any order but usually it's sequentially (I think). However, TranslateRenderJob depends on the translation units to be updated through MessageUpdateJobs before it is run because TranslateRenderJob retrieves the content for the translation page edit through the updates from that job. > > To confirm this and to make it easier to debug, I locally hacked markForTranslation() to make the jobs be `run()` immediately instead of pushing them to the queue. If the order is changed so that `getTranslationUnitJobs()` is run before `getRenderJobs()`, this bug cannot be reproduced at all but is present if it's in the current order. Note that the /en page would be updated but this is because of the edits to the unit pages which trigger the hook making the TranslateRenderJob be run repeatedly on that page. We should probably stop doing that. -------------------------- **Version**: unspecified **Severity**: minor **See Also**: https://bugzilla.wikimedia.org/show_bug.cgi?id=46716