Change Details

PHPCodeSniffer helps us stick to same coding standards across MediaWiki and it's extensions. Currently `TextExtracts` phpcs config differs from the MediaWiki one - the following sniffs are disabled: ``` MediaWiki.Commenting.FunctionComment.MissingParamComment MediaWiki.Commenting.FunctionComment.MissingParamTag MediaWiki.Commenting.FunctionComment.MissingReturn MediaWiki.Commenting.FunctionComment.ParamNameNoMatch MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment ``` Runing `phpcs` without those sniffs gives 24 errors and 9 warnings in 4 files. == Plan (YMMV) [] Enable sniffs one by one and send patches fixing the problems == Developer Notes CodeSniffer output: P5743

[PHPCodeSniffer](https://www.mediawiki.org/wiki/Continuous_integration/PHP_CodeSniffer) helps us stick to same coding standards across MediaWiki and it's extensions. Currently `TextExtracts` [phpcs config](https://phabricator.wikimedia.org/diffusion/ETEX/browse/master/.phpcs.xml) differs from the MediaWiki one - the following sniffs are disabled: ``` MediaWiki.Commenting.FunctionComment.MissingParamComment MediaWiki.Commenting.FunctionComment.MissingParamTag MediaWiki.Commenting.FunctionComment.MissingReturn MediaWiki.Commenting.FunctionComment.ParamNameNoMatch MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment ``` Runing `phpcs` without those sniffs gives 24 errors and 9 warnings in 4 files. == Plan (YMMV) [] Enable sniffs one by one and provide patches in [Wikimedia Gerrit](https://www.mediawiki.org/wiki/Gerrit/Tutorial) fixing the problems == Developer Notes CodeSniffer output: P5743

PHP[PHPCodeSniffer](https://www.mediawiki.org/wiki/Continuous_integration/PHP_CodeSniffer) helps us stick to same coding standards across MediaWiki and it's extensions. Currently `TextExtracts` [phpcs configig](https://phabricator.wikimedia.org/diffusion/ETEX/browse/master/.phpcs.xml) differs from the MediaWiki one - the following sniffs are disabled: ``` MediaWiki.Commenting.FunctionComment.MissingParamComment MediaWiki.Commenting.FunctionComment.MissingParamTag MediaWiki.Commenting.FunctionComment.MissingReturn MediaWiki.Commenting.FunctionComment.ParamNameNoMatch MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment ``` Runing `phpcs` without those sniffs gives 24 errors and 9 warnings in 4 files. == Plan (YMMV) [] Enable sniffs one by one and sendprovide patcheses in [Wikimedia Gerrit](https://www.mediawiki.org/wiki/Gerrit/Tutorial) fixing the problems == Developer Notes CodeSniffer output: P5743