Change Details

In [[ https://phabricator.wikimedia.org/diffusion/EPOE/browse/master/includes/Poem.php$87 | Poem.php ]] the extension hard codes the indentation at the level of the html element. First of all, this should be handled through a LESS file and using the existing class `mw-poem-indented`. Secondly, the directionality of the indentation should be context specific; if the poem is inside an element with class `mw-content-ltr` (as is the case with the main content of English Wikipedia, for instance) then indentation should be from the left. But if it is inside `mw-content-rtl` then the indentation should be on the right. Examples of the latter would be an Arabic poem on English Wikipedia, or an Arabic poem on Arabic Wikipedia.

Poem allows indenting the poem lines using the `:` character at the beginning of the line, and this can be nested too (e.g. `::` will result in twice the indentation amount). However, because the indentation is implemented using a `style` attribute on the `<span>` element in [[ https://phabricator.wikimedia.org/diffusion/EPOE/browse/master/includes/Poem.php$87 | Poem.php ]] and the style uses `margin-left`, this only works if the directionality of the poem is left-to-right (LTR). If the poem is RTL, this would not work, i.e. the poem will not appear indented at all, because the margin is still being applied to the left (rather than right).

IPoem allows indenting the poem lines using the `:` character at the beginning of the line, and this can be nested too (e.g. `::` will result in twice the indentation amount). However, because the indentation is implemented using a `style` attribute on the `<span>` element in [[ https://phabricator.wikimedia.org/diffusion/EPOE/browse/master/includes/Poem.php$87 | Poem.php ]] and the extension hard codes the indentation atstyle uses `margin-left`, this only works if the leveldirectionality of the html elementpoem is left-to-right (LTR). First of all, this should be handled through a LESS file and using the existing class `mw-poem-indented`. SecondlyIf the poem is RTL, the directionality of the indentation shthis would be context specific;not work, if the poem is inside an element with class `mw-content-ltr` (as is the case with the main content of English Wikipedia, for instance) then indentation should be from the left.e. But if it is inside `mw-content-rtl` then thethe poem will not appear indentation should be on the right.ted at all, Examples ofbecause the latter would be an Arabic poem on English Wikipedia, or an Arabic poem on Arabic Wikipedia.margin is still being applied to the left (rather than right).