Change Details

StreamConfig::validate() is consuming about 0.5% of index.php wall-clock time, which seems excessive for what it does: https://performance.wikimedia.org/arclamp/svgs/daily/2025-12-20.excimer-wall.index.reversed.svgz?s=EventStreamConfig&x=145.0&y=981 At a glance, I would guess the main contributors are the eager evaluation of var_export() and the regex validation. We could optimize this by only running var_export() when $settings[self::STREAM_SETTING] is actually unset. I question the value of this up-front validation entirely, though. Might it not be better to simply let it fail later if the config is bad instead of incurring this cost on every request?

StreamConfig::validate() is consuming about 0.5% of index.php wall-clock time, which seems excessive for what it does: https://performance.wikimedia.org/arclamp/svgs/daily/2025-12-20.excimer-wall.index.reversed.svgz?s=EventStreamConfig&x=145.0&y=981 At a glance, I would guess the main contributors are the eager evaluation of var_export() and the regex validation. We could optimize this by only running var_export() when $settings[self::STREAM_SETTING] is actually unset. I question the value of this up-front validation entirely, though. Might it not be better to simply let it fail later if the config is bad instead of incurring this cost on every request? In other words, what would be the harm of deleting StreamConfig::validate entirely?

StreamConfig::validate() is consuming about 0.5% of index.php wall-clock time, which seems excessive for what it does: https://performance.wikimedia.org/arclamp/svgs/daily/2025-12-20.excimer-wall.index.reversed.svgz?s=EventStreamConfig&x=145.0&y=981 At a glance, I would guess the main contributors are the eager evaluation of var_export() and the regex validation. We could optimize this by only running var_export() when $settings[self::STREAM_SETTING] is actually unset. I question the value of this up-front validation entirely, though. Might it not be better to simply let it fail later if the config is bad instead of incurring this cost on every request? In other words, what would be the harm of deleting StreamConfig::validate entirely?