Change Details

Noticed by @D3r1ck01 With patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/465288 contained; ``` 3) MediaWiki\Notifications\EchoUserNotificationGatewayTest::testMarkRead count(): Parameter must be an array or an object that implements Countable /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:131 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:98 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:15 /usr/local/var/www/wiki/mw-core/tests/phpunit/MediaWikiTestCase.php:416 /usr/local/var/www/wiki/mw-core/maintenance/doMaintenance.php:94 4) MediaWiki\Notifications\EchoUserNotificationGatewayTest::testMarkAllRead count(): Parameter must be an array or an object that implements Countable /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:131 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:98 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:29 /usr/local/var/www/wiki/mw-core/tests/phpunit/MediaWikiTestCase.php:416 /usr/local/var/www/wiki/mw-core/maintenance/doMaintenance.php:94 5) MediaWiki\Notifications\EchoUserNotificationGatewayTest::testGetNotificationCount count(): Parameter must be an array or an object that implements Countable /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:131 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:98 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:39 /usr/local/var/www/wiki/mw-core/tests/phpunit/MediaWikiTestCase.php:416 /usr/local/var/www/wiki/mw-core/maintenance/doMaintenance.php:94 6) MediaWiki\Notifications\EchoUserNotificationGatewayTest::testGetUnreadNotifications count(): Parameter must be an array or an object that implements Countable /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:131 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:98 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:56 /usr/local/var/www/wiki/mw-core/tests/phpunit/MediaWikiTestCase.php:416 /usr/local/var/www/wiki/mw-core/maintenance/doMaintenance.php:94 ``` On `master` before patch above ``` There were 4 errors: 1) EchoUserNotificationGatewayTest::testMarkRead count(): Parameter must be an array or an object that implements Countable /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:10 /usr/local/var/www/wiki/mw-core/tests/phpunit/MediaWikiTestCase.php:416 /usr/local/var/www/wiki/mw-core/maintenance/doMaintenance.php:94 2) EchoUserNotificationGatewayTest::testMarkAllRead count(): Parameter must be an array or an object that implements Countable /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:24 /usr/local/var/www/wiki/mw-core/tests/phpunit/MediaWikiTestCase.php:416 /usr/local/var/www/wiki/mw-core/maintenance/doMaintenance.php:94 3) EchoUserNotificationGatewayTest::testGetNotificationCount count(): Parameter must be an array or an object that implements Countable /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:34 /usr/local/var/www/wiki/mw-core/tests/phpunit/MediaWikiTestCase.php:416 /usr/local/var/www/wiki/mw-core/maintenance/doMaintenance.php:94 4) EchoUserNotificationGatewayTest::testGetUnreadNotifications count(): Parameter must be an array or an object that implements Countable /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:51 /usr/local/var/www/wiki/mw-core/tests/phpunit/MediaWikiTestCase.php:416 /usr/local/var/www/wiki/mw-core/maintenance/doMaintenance.php:94 ```

Noticed by @D3r1ck01 ``` 20:32:15 1) EchoUserNotificationGatewayTest::testMarkRead 20:32:15 count(): Parameter must be an array or an object that implements Countable 20:32:15 20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126 20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93 20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:10 20:32:15 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424 20:32:15 /workspace/src/maintenance/doMaintenance.php:94 20:32:15 20:32:15 2) EchoUserNotificationGatewayTest::testMarkAllRead 20:32:15 count(): Parameter must be an array or an object that implements Countable 20:32:15 20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126 20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93 20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:24 20:32:15 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424 20:32:15 /workspace/src/maintenance/doMaintenance.php:94 20:32:15 20:32:15 3) EchoUserNotificationGatewayTest::testGetNotificationCount 20:32:15 count(): Parameter must be an array or an object that implements Countable 20:32:15 20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126 20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93 20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:34 20:32:15 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424 20:32:15 /workspace/src/maintenance/doMaintenance.php:94 20:32:15 20:32:15 4) EchoUserNotificationGatewayTest::testGetUnreadNotifications 20:32:15 count(): Parameter must be an array or an object that implements Countable 20:32:15 20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126 20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93 20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:51 20:32:15 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424 20:32:15 /workspace/src/maintenance/doMaintenance.php:94 ``` https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/22/consoleFull Can be verified by commenting "check experimental" on a patch to trigger the PHP 7.2 job.

Noticed by @D3r1ck01 With patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/465288 contained; ``` 3) MediaWiki\Notifications\20:32:15 1) EchoUserNotificationGatewayTest::testMarkRead 20:32:15 count(): Parameter must be an array or an object that implements Countable 20:32:15 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:13126 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:983 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:150 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/tests/phpunit/MediaWikiTestCase.php:41624 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/maintenance/doMaintenance.php:94 20:32:15 4) MediaWiki\Notifications\20:32:15 2) EchoUserNotificationGatewayTest::testMarkAllRead 20:32:15 count(): Parameter must be an array or an object that implements Countable 20:32:15 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:13126 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:983 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:294 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/tests/phpunit/MediaWikiTestCase.php:41624 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/maintenance/doMaintenance.php:94 20:32:15 5) MediaWiki\Notifications\20:32:15 3) EchoUserNotificationGatewayTest::testGetNotificationCount 20:32:15 count(): Parameter must be an array or an object that implements Countable 20:32:15 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:13126 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:983 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:394 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/tests/phpunit/MediaWikiTestCase.php:41624 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/maintenance/doMaintenance.php:94 20:32:15 6) MediaWiki\Notifications\20:32:15 4) EchoUserNotificationGatewayTest::testGetUnreadNotifications 20:32:15 count(): Parameter must be an array or an object that implements Countable 20:32:15 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:13126 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:983 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:561 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/tests/phpunit/MediaWikiTestCase.php:41624 /usr/local/var/www/wiki/mw-core20:32:15 /workspace/src/maintenance/doMaintenance.php:94 ``` On `master` before patch above ``` There were 4 errors:https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/22/consoleFull 1) EchoUserNotificationGatewayTest::testMarkRead count(): Parameter must be an array or an object that implements Countable /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:10 /usr/local/var/www/wiki/mw-core/tests/phpunit/MediaWikiTestCase.php:416 /usr/local/var/www/wiki/mw-core/maintenance/doMaintenance.php:94 2) EchoUserNotificationGatewayTest::testMarkAllRead count(): Parameter must be an array or an object that implements Countable /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:24 /usr/local/var/www/wiki/mw-core/tests/phpunit/MediaWikiTestCase.php:416 /usr/local/var/www/wiki/mw-core/maintenance/doMaintenance.php:94 3) EchoUserNotificationGatewayTest::testGetNotificationCount count(): Parameter must be an array or an object that implements Countable /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:34 /usr/local/var/www/wiki/mw-core/tests/phpunit/MediaWikiTestCase.php:416 /usr/local/var/www/wiki/mw-core/maintenance/doMaintenance.php:94 4) EchoUserNotificationGatewayTest::testGetUnreadNotifications count(): Parameter must be an array or an object that implements Countable /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93 /usr/local/var/www/wiki/mw-core/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:51 /usr/local/var/www/wiki/mw-core/tests/phpunit/MediaWikiTestCase.php:416 /usr/local/var/www/wiki/mw-core/maintenance/doMaintenance.php:94 ```Can be verified by commenting "check experimental" on a patch to trigger the PHP 7.2 job.