Change Details

Currently rlModuleLoader.js is our only non-View code which has no test coverage and this makes me a sad panda. This task aims to make this 100%. The rlModuleLoader wraps mw.loader.using and shows a spinner overlay until the module has finished loading = Developer notes Add test coverage for rlModuleLoader.js = Sign off steps [] Record [[ https://www.mediawiki.org/wiki/Reading/Web/Projects/Invest_in_the_MobileFrontend_%26_MinervaNeue_frontend_architecture/Progress?useskin=vector#Impact_on_bytes_shipped | progress ]] Coverage should be 100%. If not, please make a note on the table.

Currently rlModuleLoader.js is our only non-View code which has no test coverage and this makes me a sad panda. This task aims to make this 100%. The rlModuleLoader wraps mw.loader.using and shows a spinner overlay until the module has finished loading = Developer notes Add test coverage for rlModuleLoader.js Risks: 1 function with various different code paths with async behaviour (with reject/done resolution behaviour), 1 optional parameter, use of new keyword = Sign off steps [] Record [[ https://www.mediawiki.org/wiki/Reading/Web/Projects/Invest_in_the_MobileFrontend_%26_MinervaNeue_frontend_architecture/Progress?useskin=vector#Impact_on_bytes_shipped | progress ]] Coverage should be 100%. If not, please make a note on the table.

Currently rlModuleLoader.js is our only non-View code which has no test coverage and this makes me a sad panda. This task aims to make this 100%. The rlModuleLoader wraps mw.loader.using and shows a spinner overlay until the module has finished loading = Developer notes Add test coverage for rlModuleLoader.js Risks: 1 function with various different code paths with async behaviour (with reject/done resolution behaviour), 1 optional parameter, use of new keyword = Sign off steps [] Record [[ https://www.mediawiki.org/wiki/Reading/Web/Projects/Invest_in_the_MobileFrontend_%26_MinervaNeue_frontend_architecture/Progress?useskin=vector#Impact_on_bytes_shipped | progress ]] Coverage should be 100%. If not, please make a note on the table.