=====Problem to solve
There are some problematic users who continually violate file upload policies & guidelines, but should otherwise be retained on the wiki as constructive contributors. A sitewide block is not an appropriate way to handle these situations.
------
===Proposed solution
It would be useful to be able to *only* block users from uploading files.
Allowing them to keep editing allows them to contact people who can help explain copyright issues to them and shouldn't cause the same outrage that sitewide blocking tends to.
------
===Acceptance criteria
//Note: These criteria are relevant after T2674 is complete://
* On Special:Block, under 'Actions to block' add a checkbox for `Uploading files`
** If the 'Editing' checkbox is checked and the 'Sitewide' radio button is selected, the 'Uploading files' checkbox should be checked and marked as disabled. (This is the default state of Special:Block)The checkbox should be unchecked by default
** If the 'Editing' checkboxes is unchecked or** The checkbox should be marked as disabled unless the 'Partial' radio button is selected, the 'Uploading files' checkbox should be be enabled but marked as checked by default.
** If a user has unchecked 'Editing' or selected 'Partial' but later re-checks 'Sitewide' the 'Uploading files' checkbox should become checked and marked as disabledtoggles either the 'Editing' checkbox or the Sitewide/Partial radio buttons, the checkbox should save whatever state the user configured it as. The state can be discarded on submit if the block is non-editing or sitewide.
* When a block is saved with the 'Uploading files' checkbox selected, the target user should not be able to upload files via API, via any tool in any editor, or via any Special page.
** Error messages should display appropriately (see below)
*** Special:Upload
*** Special:UploadWizard
*** Uploading a file in an editor (visualeditor, 2017 source editor, or 2010 source editor.) — I believe they all use the same tool.
* When a Partial block is saved with the 'Uploading files' checkbox selected, the log items should indicate uploading files is part of the block
** e.g. //23:20, 26 November 2018 AdminUsername (talk | contribs | block) blocked BadUser (talk | contribs) from editing Page(s) and uploading files with an expiration time of N (autoblock disabled) (unblock | change block)//
** e.g. //23:20, 26 November 2018 AdminUsername (talk | contribs | block) blocked BadUser (talk | contribs) from uploading files with an expiration time of N (autoblock disabled) (unblock | change block)//
** similar log messages should exist for modifying blocks to add or remove upload, the log items should indicate uploading files isand to include namespaces within the part of theial block.
* Special:BlockList should display that a user is blocked from uploading files as a bullet in the 'Block parameters' column
------
====Designs
{M255}
------
====Error message
For Special pages:
```
<strong>Your username or IP address has been blocked from uploading files. You can still edit other pages on this wiki.</strong> You can view the full block details at [[Special:MyContributions|account contributions]].
The block was made by $1.
The reason given is <em>$2</em>.
* Start of block: $8
* Expiration of block: $6
* Intended blockee: $7
* Block ID #$5
```
For the in-editor tools:
| {F26309395} | {F26309436} |
| This error message appears on upload failure | Messages appear on opening of the tool. |
| Acceptable | Preferred |
```
You have been blocked from uploading files.
```
If we can add links to this error message, we should add a 'Details.' link which points to `Special:BlockListwpTarget=USERNAME`