Change Details

The Varnish caching of banners served via Special:BannerLoader is "hit-for-pass", which means cachability of an item isn't known until it's actually served up by the MW backend. Cache header values are set like [[ https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/731d248f7d7c9a265193500d41fced0fa691de39/special/SpecialBannerLoader.php#L72-L84 | so ]], in SpecialBannerLoader. We should review this setup to see if it's currently optimal. Review should include any relevant vlc (varnish setup) code that comes into play, too. As part of this update, we might well turn off caching for output for at caught errors.

The Varnish caching of banners served via Special:BannerLoader is "hit-for-pass", which means cachability of an item isn't known until it's actually served up by the MW backend. Cache header values are set in [[ https://gerrit.wikimedia.org/g/mediawiki/extensions/CentralNotice/+/d50f2f30fe3ce3a8e5d4a4c082f388ed138995be/includes/specials/SpecialBannerLoader.php#160 | SpecialBannerLoader.php ]]. We should review this setup to see if it's currently optimal. Review should include any relevant VCL code (varnish config) that comes into play, too. As part of this update, we might well turn off caching for output for at caught errors.

The Varnish caching of banners served via Special:BannerLoader is "hit-for-pass", which means cachability of an item isn't known until it's actually served up by the MW backend. Cache header values are set like [[ https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/731d248f7d7c9a265193500d41fced0fa691de39/special/SpecialBannerLoader.php#L72-L84 | so ]], in SpecialBannerLoaderin [[ https://gerrit.wikimedia.org/g/mediawiki/extensions/CentralNotice/+/d50f2f30fe3ce3a8e5d4a4c082f388ed138995be/includes/specials/SpecialBannerLoader.php#160 | SpecialBannerLoader.php ]]. We should review this setup to see if it's currently optimal. Review should include any relevant vlcVCL code (varnish setup) codeconfig) that comes into play, too. As part of this update, we might well turn off caching for output for at caught errors.