Change Details

The method uses global state (bad) and with ActorStore introduction we can use UserIdentityLookup to fetch UserIdentity by user ID and get it's name. This will benefit from charing the in-process cache with everything else. Deployed extensions: [x] FlaggedRevs https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/683709 [x] Jade T281418 Third-party extensions: [] UsersWatchlist - non-gerrit extension [x] ArticleFeedbackv5 [x] BatchUserRights [x] ConfirmAccount [x] NewUserNotif CodeSearch: https://codesearch.wmcloud.org/search/?q=%5CbUser%5Cs*%3A%3A%5Cs*whoIs%5Cb&i=nope&files=&excludeFiles=&repos=

The method uses global state (bad) and with ActorStore introduction we can use UserIdentityLookup to fetch UserIdentity by user ID and get it's name. This will benefit from charing the in-process cache with everything else. Deployed extensions: [x] FlaggedRevs https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/683709 [x] Jade T281418 [] GlobalBlocking Third-party extensions: [] UsersWatchlist - non-gerrit extension [x] ArticleFeedbackv5 [x] BatchUserRights [x] ConfirmAccount [x] NewUserNotif CodeSearch: https://codesearch.wmcloud.org/search/?q=%5CbUser%5Cs*%3A%3A%5Cs*whoIs%5Cb&i=nope&files=&excludeFiles=&repos=

The method uses global state (bad) and with ActorStore introduction we can use UserIdentityLookup to fetch UserIdentity by user ID and get it's name. This will benefit from charing the in-process cache with everything else. Deployed extensions: [x] FlaggedRevs https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/683709 [x] Jade T281418 [] GlobalBlocking Third-party extensions: [] UsersWatchlist - non-gerrit extension [x] ArticleFeedbackv5 [x] BatchUserRights [x] ConfirmAccount [x] NewUserNotif CodeSearch: https://codesearch.wmcloud.org/search/?q=%5CbUser%5Cs*%3A%3A%5Cs*whoIs%5Cb&i=nope&files=&excludeFiles=&repos=