Change Details

The property suggester keeps suggesting completely inappropriate human properties to me on items which are not humans. For example, right now, https://www.wikidata.org/wiki/Q504582 has the properties * `P31` (instance of) * `P373` (Commons category) * `P625` (coordinate location) * `P17` (country) * `P18` (image) * `P935` (Commons gallery) * `P885` (origin of the watercourse) * `P1599` (GeoNames ID) * `P646` (Freebase ID) * `P214` (VIAF ID) Of those, 6 are generic and can apply to a variety of items, 3 are specific to geographical features and 1 is fairly generic but not usually found on humans. Despite that, if I go to add a new property, the suggested properties are: * `P131` (located in the administrative territorial entity) * `P21` (sex or gender) * `P569` (date of birth) * `P735` (given name) * `P27` (country of citizenship) * `P106` (occupation) * `P19` (place of birth) The first of these would be a good property. The other 6 are all specific to humans (and other living beings) and should definitely //not// be added to rivers. I can't see why it's so biased towards human properties here. I would expect to see properties relating to rivers (e.g. `P403` (mouth of the watercourse) would actually be a useful suggestion) or at least properties relating to geographical features rather than humans. -------- Suggested solutions from discussion (please complete): - allow weighting of properties with classifying values (P31 / P279) , compare to others. - add P106 to properties with classifying values - if item has P17, check if P17 on property matches (same value or no property), if not: don't suggest property #patch-for-review: * [x] https://github.com/Wikidata-lib/PropertySuggester/pull/191 * [x] https://github.com/Wikidata-lib/PropertySuggester/pull/189 * [ ] https://github.com/Wikidata-lib/PropertySuggester/pull/192 * [ ] https://github.com/Wikidata-lib/PropertySuggester/pull/179

The property suggester keeps suggesting completely inappropriate human properties to me on items which are not humans. For example, right now, https://www.wikidata.org/wiki/Q504582 has the properties * `P31` (instance of) * `P373` (Commons category) * `P625` (coordinate location) * `P17` (country) * `P18` (image) * `P935` (Commons gallery) * `P885` (origin of the watercourse) * `P1599` (GeoNames ID) * `P646` (Freebase ID) * `P214` (VIAF ID) Of those, 6 are generic and can apply to a variety of items, 3 are specific to geographical features and 1 is fairly generic but not usually found on humans. Despite that, if I go to add a new property, the suggested properties are: * `P131` (located in the administrative territorial entity) * `P21` (sex or gender) * `P569` (date of birth) * `P735` (given name) * `P27` (country of citizenship) * `P106` (occupation) * `P19` (place of birth) The first of these would be a good property. The other 6 are all specific to humans (and other living beings) and should definitely //not// be added to rivers. I can't see why it's so biased towards human properties here. I would expect to see properties relating to rivers (e.g. `P403` (mouth of the watercourse) would actually be a useful suggestion) or at least properties relating to geographical features rather than humans. -------- Suggested solutions from discussion (please complete): - allow weighting of properties with classifying values (P31 / P279) , compare to others. - add P106 to properties with classifying values - if item has P17, check if P17 on property matches (same value or no property), if not: don't suggest property #patch-for-review: * [x] https://github.com/Wikidata-lib/PropertySuggester/pull/191 * [x] https://github.com/Wikidata-lib/PropertySuggester/pull/189 * [x] https://github.com/Wikidata-lib/PropertySuggester/pull/192 * [ ] https://github.com/Wikidata-lib/PropertySuggester/pull/179

The property suggester keeps suggesting completely inappropriate human properties to me on items which are not humans. For example, right now, https://www.wikidata.org/wiki/Q504582 has the properties * `P31` (instance of) * `P373` (Commons category) * `P625` (coordinate location) * `P17` (country) * `P18` (image) * `P935` (Commons gallery) * `P885` (origin of the watercourse) * `P1599` (GeoNames ID) * `P646` (Freebase ID) * `P214` (VIAF ID) Of those, 6 are generic and can apply to a variety of items, 3 are specific to geographical features and 1 is fairly generic but not usually found on humans. Despite that, if I go to add a new property, the suggested properties are: * `P131` (located in the administrative territorial entity) * `P21` (sex or gender) * `P569` (date of birth) * `P735` (given name) * `P27` (country of citizenship) * `P106` (occupation) * `P19` (place of birth) The first of these would be a good property. The other 6 are all specific to humans (and other living beings) and should definitely //not// be added to rivers. I can't see why it's so biased towards human properties here. I would expect to see properties relating to rivers (e.g. `P403` (mouth of the watercourse) would actually be a useful suggestion) or at least properties relating to geographical features rather than humans. -------- Suggested solutions from discussion (please complete): - allow weighting of properties with classifying values (P31 / P279) , compare to others. - add P106 to properties with classifying values - if item has P17, check if P17 on property matches (same value or no property), if not: don't suggest property #patch-for-review: * [x] https://github.com/Wikidata-lib/PropertySuggester/pull/191 * [x] https://github.com/Wikidata-lib/PropertySuggester/pull/189 * [ * [x] https://github.com/Wikidata-lib/PropertySuggester/pull/192 * [ ] https://github.com/Wikidata-lib/PropertySuggester/pull/179