Change Details

Following the migration test run, I'm seeing some issues with the display of old Vector when using the `useskin` querystring parameter. # Test case 1 - Load incognito window - Go to the URL https://en.wikipedia.beta.wmflabs.org/wiki/Spain?useskin=vector Expected: I should see the old Vector. Actual: I see the modern Vector experience. # Test case 1 - Sign in - Set vector-2022 as your default skin - Go to the URL https://en.wikipedia.beta.wmflabs.org/wiki/Spain?useskin=vector Expected: I should see the old Vector. Actual: I see the modern Vector experience. # Developer notes When VectorSkinMigrationMode is enabled, then skinversion query string parameter should cease to work. For anons, wgDefaultSkin should be the source of truth in this situation for which skin to use. For logged in users, we consult the user preferences table: * If skin is set to 'vector' and skin version is 2, we give them modern Vector. * If skin is set to 'vector' and skin version is 2, but skinversion query string parameter is set to 1, we give them legacy to allow them to override * If skin is set to 'vector' and skin version is 1, we give them old Vector.

Following the migration test run, I'm seeing some issues with the display of old Vector when using the `useskin` querystring parameter. # QA For production test in eu.wikipedia.org ## Test case 1 - Load incognito window - Go to the URL https://en.wikipedia.beta.wmflabs.org/wiki/Spain?useskin=vector Expected: I should see the old Vector. Actual: I see the modern Vector experience. ## Test case 1 - Sign in - Set vector-2022 as your default skin - Go to the URL https://en.wikipedia.beta.wmflabs.org/wiki/Spain?useskin=vector Expected: I should see the old Vector. Actual: I see the modern Vector experience. # Developer notes When VectorSkinMigrationMode is enabled, then skinversion query string parameter should cease to work. For anons, wgDefaultSkin should be the source of truth in this situation for which skin to use. For logged in users, we consult the user preferences table: * If skin is set to 'vector' and skin version is 2, we give them modern Vector. * If skin is set to 'vector' and skin version is 2, but skinversion query string parameter is set to 1, we give them legacy to allow them to override * If skin is set to 'vector' and skin version is 1, we give them old Vector.

Following the migration test run, I'm seeing some issues with the display of old Vector when using the `useskin` querystring parameter. # QA For production test in eu.wikipedia.org ## Test case 1 - Load incognito window - Go to the URL https://en.wikipedia.beta.wmflabs.org/wiki/Spain?useskin=vector Expected: I should see the old Vector. Actual: I see the modern Vector experience. ## Test case 1 - Sign in - Set vector-2022 as your default skin - Go to the URL https://en.wikipedia.beta.wmflabs.org/wiki/Spain?useskin=vector Expected: I should see the old Vector. Actual: I see the modern Vector experience. # Developer notes When VectorSkinMigrationMode is enabled, then skinversion query string parameter should cease to work. For anons, wgDefaultSkin should be the source of truth in this situation for which skin to use. For logged in users, we consult the user preferences table: * If skin is set to 'vector' and skin version is 2, we give them modern Vector. * If skin is set to 'vector' and skin version is 2, but skinversion query string parameter is set to 1, we give them legacy to allow them to override * If skin is set to 'vector' and skin version is 1, we give them old Vector.