Change Details

Any changes to spicerack require a manual deploy, which is painful. Move the Elasticsearch cluster config into either the cookbooks repo directly, or puppet. (Cookbooks sounds easier but the code comment mentions puppet) This is where the config that needs to be pulled out lives: https://gerrit.wikimedia.org/g/operations/software/spicerack/+/master/spicerack/elasticsearch_cluster.py#23 **Todo:** * Create a YAML spicerack configuration file that mimics the current config constant. Spicerack configurations are [[ https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/refs/heads/production/modules/profile/manifests/spicerack.pp | managed in puppet ]]. This configuration can be static at first, but ideally it should be created from state already in puppet (I'm not sure if this is easily doable - @EBernhardson might have some ideas) * In [[ https://gerrit.wikimedia.org/g/operations/software/spicerack/+/master/spicerack/elasticsearch_cluster.py#23 | Spicerack ]], replace the configuration constant with the same data, but loaded from a configuration file that is passed to the elasticsearch_cluster module. See other [[ https://gerrit.wikimedia.org/r/plugins/gitiles/operations/software/spicerack/+/master/spicerack/__init__.py#482 | examples of `load_yaml_config` in the Spicerack class ]].

Any changes to spicerack require a manual deploy, which is painful. Move the Elasticsearch cluster config into either the cookbooks repo directly, or puppet. (Cookbooks sounds easier but the code comment mentions puppet) This is where the config that needs to be pulled out lives: https://gerrit.wikimedia.org/g/operations/software/spicerack/+/master/spicerack/elasticsearch_cluster.py#23 **Todo:** * Create a YAML spicerack configuration file that mimics the current config constant. Spicerack configurations are [[ https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/refs/heads/production/modules/profile/manifests/spicerack.pp | managed in puppet ]]. This configuration can be static at first, but ideally it should be created from state already in puppet (I'm not sure if this is easily doable - @EBernhardson might have some ideas) * In [[ https://gerrit.wikimedia.org/g/operations/software/spicerack/+/master/spicerack/elasticsearch_cluster.py#23 | Spicerack ]], replace the configuration constant with the same data, but loaded from a configuration file that is passed to the elasticsearch_cluster module. See other examples of `load_yaml_config` [[ https://gerrit.wikimedia.org/r/plugins/gitiles/operations/software/spicerack/+/master/spicerack/__init__.py#482 | in the Spicerack class ]].

Any changes to spicerack require a manual deploy, which is painful. Move the Elasticsearch cluster config into either the cookbooks repo directly, or puppet. (Cookbooks sounds easier but the code comment mentions puppet) This is where the config that needs to be pulled out lives: https://gerrit.wikimedia.org/g/operations/software/spicerack/+/master/spicerack/elasticsearch_cluster.py#23 **Todo:** * Create a YAML spicerack configuration file that mimics the current config constant. Spicerack configurations are [[ https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/refs/heads/production/modules/profile/manifests/spicerack.pp | managed in puppet ]]. This configuration can be static at first, but ideally it should be created from state already in puppet (I'm not sure if this is easily doable - @EBernhardson might have some ideas) * In [[ https://gerrit.wikimedia.org/g/operations/software/spicerack/+/master/spicerack/elasticsearch_cluster.py#23 | Spicerack ]], replace the configuration constant with the same data, but loaded from a configuration file that is passed to the elasticsearch_cluster module. See other examples of `load_yaml_config` [[ https://gerrit.wikimedia.org/r/plugins/gitiles/operations/software/spicerack/+/master/spicerack/__init__.py#482 | examples of `load_yaml_config` in the Spicerack class ]].