Change Details

Status -- create_isbn_edition.py originally written by Geert Van Pamel was added 3 years ago with Pywikibot 7.7 but I am unsure whether this is ever used from this repository and always behind the initial source at [[ https://github.com/geertivp/Pywikibot/blob/main/create_isbn_edition.py | https://github.com/geertivp ]]. Overall it is hardly maintainable ind keep in sync with it. - the [[ https://github.com/geertivp/Pywikibot/commit/9401f8778c341b56f9bc47bd2acb1cd1034a9ded | last change ]] wasn't ported to pywikibot - different repositories with different further development are difficult to keep in sync if they after changes - the script uses a lot of global variables which is generally considered bad practice and should be avoided if possible. - the script is in critical risc categoty with a cyclomatic complexity of ~80 - in result the script is vulnerable to unintended changes, difficult to maintain, has reduced modularity and probably performance issues - finally there are a lot of open tasks according this script for further development Proposal -- I propose to remove `create_isbn_edition.py` from Pywikibot scripts package. It is still available under the repository https://github.com/geertivp/Pywikibot which hold several scripts. With [[https://doc.wikimedia.org/pywikibot/master/entrypoint.html|code entry point for foreign scripts]] introduced in Pywikibot 9.4 the whole script package could be published by the maintainer as a separate package based on Pywikibot like we do it with [[https://pypi.org/project/pywikibot-scripts/|pywikibot-scripts]]. See also T377066.

Status -- create_isbn_edition.py originally written by Geert Van Pamel was added 3 years ago with Pywikibot 7.7 but I am unsure whether this is ever used from this repository and always behind the initial source at [[ https://github.com/geertivp/Pywikibot/blob/main/create_isbn_edition.py | https://github.com/geertivp ]]. Overall it is hardly maintainable ind keep in sync with it. - the [[ https://github.com/geertivp/Pywikibot/commit/9401f8778c341b56f9bc47bd2acb1cd1034a9ded | last change ]] wasn't ported to pywikibot - different repositories with different further development are difficult to keep in sync if they after changes - the script uses a lot of global variables which is generally considered bad practice and should be avoided if possible. - the script is in critical risc category with a cyclomatic complexity of ~80 - in result the script is vulnerable to unintended changes, difficult to maintain, has reduced modularity and probably performance issues - finally there are a lot of open tasks according this script for further development Proposal -- I propose to remove `create_isbn_edition.py` from Pywikibot scripts package. It is still available under the repository https://github.com/geertivp/Pywikibot which hold several scripts. With [[https://doc.wikimedia.org/pywikibot/master/entrypoint.html|code entry point for foreign scripts]] introduced in Pywikibot 9.4 the whole script package could be published by the maintainer as a separate package based on Pywikibot like we do it with [[https://pypi.org/project/pywikibot-scripts/|pywikibot-scripts]]. See also T377066.

Status -- create_isbn_edition.py originally written by Geert Van Pamel was added 3 years ago with Pywikibot 7.7 but I am unsure whether this is ever used from this repository and always behind the initial source at [[ https://github.com/geertivp/Pywikibot/blob/main/create_isbn_edition.py | https://github.com/geertivp ]]. Overall it is hardly maintainable ind keep in sync with it. - the [[ https://github.com/geertivp/Pywikibot/commit/9401f8778c341b56f9bc47bd2acb1cd1034a9ded | last change ]] wasn't ported to pywikibot - different repositories with different further development are difficult to keep in sync if they after changes - the script uses a lot of global variables which is generally considered bad practice and should be avoided if possible. - the script is in critical risc categotyry with a cyclomatic complexity of ~80 - in result the script is vulnerable to unintended changes, difficult to maintain, has reduced modularity and probably performance issues - finally there are a lot of open tasks according this script for further development Proposal -- I propose to remove `create_isbn_edition.py` from Pywikibot scripts package. It is still available under the repository https://github.com/geertivp/Pywikibot which hold several scripts. With [[https://doc.wikimedia.org/pywikibot/master/entrypoint.html|code entry point for foreign scripts]] introduced in Pywikibot 9.4 the whole script package could be published by the maintainer as a separate package based on Pywikibot like we do it with [[https://pypi.org/project/pywikibot-scripts/|pywikibot-scripts]]. See also T377066.