Change Details

Old edited articles without pageviews should not appear in the article list. However due to the changes in the parent task this is now possible, although very rare. It would be nice to revise the logic to make it more robust. More context: >>! In T351898#9358772, @Sgs wrote: >The changes in [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/977141 | 977141 ]] could be slightly changing the articles list output since "old edited" articles with 0 page views would added to `recentEditsWithoutPageviews`. The problem is rather semantic than breaking the functionality but it could be confusing for uses if they get to see it. Since 0-views edited articles is almost impossible scenario I don't think this is blocker.

Old edited articles without pageviews should not appear in the article list. However due to the changes in the parent task this is now possible, although very rare. The `sortAndFilter` function expects the json data to contain date-keys for the days with 0 views which is no longer true, see [[ https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GrowthExperiments/+/refs/changes/41/977141/6/includes/UserImpact/UserImpactFormatter.php#65 | source ]]. It would be nice to revise the logic to make it more robust. More context: >>! In T351898#9358772, @Sgs wrote: >The changes in [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/977141 | 977141 ]] could be slightly changing the articles list output since "old edited" articles with 0 page views would added to `recentEditsWithoutPageviews`. The problem is rather semantic than breaking the functionality but it could be confusing for uses if they get to see it. Since 0-views edited articles is almost impossible scenario I don't think this is blocker.

Old edited articles without pageviews should not appear in the article list. However due to the changes in the parent task this is now possible, although very rare. The `sortAndFilter` function expects the json data to contain date-keys for the days with 0 views which is no longer true, see [[ https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GrowthExperiments/+/refs/changes/41/977141/6/includes/UserImpact/UserImpactFormatter.php#65 | source ]]. It would be nice to revise the logic to make it more robust. More context: >>! In T351898#9358772, @Sgs wrote: >The changes in [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/977141 | 977141 ]] could be slightly changing the articles list output since "old edited" articles with 0 page views would added to `recentEditsWithoutPageviews`. The problem is rather semantic than breaking the functionality but it could be confusing for uses if they get to see it. Since 0-views edited articles is almost impossible scenario I don't think this is blocker.