Change Details

Data providers that do too much work or are “too smart” repeatedly cause problems in CI (see e.g. T369357 and T371460). We should refactor our tests to do as little work as possible in the data providers, and shift everything else into the tests themselves. See also the parent task and the subtasks. - [x] {T337154} - [x] {T337153} - [x] {T337151} - [] {T337152} (technically WMDE isn’t responsible for this one, but as it’s not a lot of data providers, I’m inclined to say we should JFDI tbh) - [x] {T337150} - [x] {T337148}

Data providers that do too much work or are “too smart” repeatedly cause problems in CI (see e.g. T369357 and T371460). We should refactor our tests to do as little work as possible in the data providers, and shift everything else into the tests themselves. See also the parent task and the subtasks. - [x] {T337154} - [x] {T337153} - [x] {T337151} - [x] {T337152} (technically WMDE isn’t responsible for this one, but as it’s not a lot of data providers, I’m inclined to say we should JFDI tbh) - [x] {T337150} - [x] {T337148}

Data providers that do too much work or are “too smart” repeatedly cause problems in CI (see e.g. T369357 and T371460). We should refactor our tests to do as little work as possible in the data providers, and shift everything else into the tests themselves. See also the parent task and the subtasks. - [x] {T337154} - [x] {T337153} - [x] {T337151} - [x] {T337152} (technically WMDE isn’t responsible for this one, but as it’s not a lot of data providers, I’m inclined to say we should JFDI tbh) - [x] {T337150} - [x] {T337148}