Change Details

DatabaseBlock constructor accepts 'byText' property with blocker's name, and 'by' property with a blocker ID. In cross-wiki blocking it's extremely easy to make a mistake and attribute the blocker to a local user with the same name or ID. Instead, these options for DatabaseBlock have to be hard-deprecated. The only remaining option should be providing a UserIdentity as a 'by' option. Steps: 1. Use codesearch to find all extensions that provide these options incorrectly. Make a list on this task. Fix extensions. 2. Fix core. Quick look over codesearch reveals that these options are mostly used in test codeso perhaps they can be removed without deprecation.

DatabaseBlock constructor accepts 'byText' property with blocker's name, and 'by' property with a blocker ID or, since [I144603516b](https://gerrit.wikimedia.org/r/c/mediawiki/core/+/668736), a `UserIdentity`. In cross-wiki blocking it's extremely easy to make a mistake and attribute the blocker to a local user with the same name or ID. Instead, these options for DatabaseBlock have to be hard-deprecated. The only remaining option should be providing a UserIdentity as a 'by' option. Steps: 1. Use codesearch to find all extensions that provide these options incorrectly. Make a list on this task. Fix extensions. 2. Fix core. Quick look over codesearch reveals that these options are mostly used in test codeso perhaps they can be removed without deprecation.

DatabaseBlock constructor accepts 'byText' property with blocker's name, and 'by' property with a blocker ID or, since [I144603516b](https://gerrit.wikimedia.org/r/c/mediawiki/core/+/668736), a `UserIdentity`. In cross-wiki blocking it's extremely easy to make a mistake and attribute the blocker to a local user with the same name or ID. Instead, these options for DatabaseBlock have to be hard-deprecated. The only remaining option should be providing a UserIdentity as a 'by' option. Steps: 1. Use codesearch to find all extensions that provide these options incorrectly. Make a list on this task. Fix extensions. 2. Fix core. Quick look over codesearch reveals that these options are mostly used in test codeso perhaps they can be removed without deprecation.