Change Details

@Raymond noticed that the AC/DC gadget ([JS code](https://commons.wikimedia.org/wiki/MediaWiki:Gadget-ACDC.js), [permalink](https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-ACDC.js&oldid=810052214)) is broken – MediaWiki replaces it with a parse error: ``` $ curl 'https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=ext.gadget.ACDC&skin=vector&version=ztntf' mw.loader.impl(function(){return["ext.gadget.ACDC@",function($,jQuery,require,module){/* MediaWiki:Gadget-ACDC.js */ mw.log.error("Parse error: Unexpected: function on line 20"); }];}); ``` Presumably this is due to the introduction of Peast with this week’s train. Unfortunately, line 20 in the gadget is quite long, so it’s not immediately clear where exactly the syntax checker encounters an error. (The code should be valid, it’s emitted by webpack and was working previously.) --- Summary so far: reduced to `(a=1,2)`; worked around in AC/DC; no other gadget likely to be affected; [upstream #65](https://github.com/mck89/peast/issues/65).

@Raymond noticed that the AC/DC gadget ([JS code](https://commons.wikimedia.org/wiki/MediaWiki:Gadget-ACDC.js), [permalink](https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-ACDC.js&oldid=810052214)) is broken – MediaWiki replaces it with a parse error: ``` $ curl 'https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=ext.gadget.ACDC&skin=vector&version=ztntf' mw.loader.impl(function(){return["ext.gadget.ACDC@",function($,jQuery,require,module){/* MediaWiki:Gadget-ACDC.js */ mw.log.error("Parse error: Unexpected: function on line 20"); }];}); ``` Presumably this is due to the introduction of Peast with this week’s train. Unfortunately, line 20 in the gadget is quite long, so it’s not immediately clear where exactly the syntax checker encounters an error. (The code should be valid, it’s emitted by webpack and was working previously.) --- Summary: reduced to `(a=1,2)`; worked around in AC/DC; no other gadget likely to be affected; [upstream #65](https://github.com/mck89/peast/issues/65); fixed in Peast 0.16, to be deployed with 1.42.0-wmf.14.

@Raymond noticed that the AC/DC gadget ([JS code](https://commons.wikimedia.org/wiki/MediaWiki:Gadget-ACDC.js), [permalink](https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-ACDC.js&oldid=810052214)) is broken – MediaWiki replaces it with a parse error: ``` $ curl 'https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=ext.gadget.ACDC&skin=vector&version=ztntf' mw.loader.impl(function(){return["ext.gadget.ACDC@",function($,jQuery,require,module){/* MediaWiki:Gadget-ACDC.js */ mw.log.error("Parse error: Unexpected: function on line 20"); }];}); ``` Presumably this is due to the introduction of Peast with this week’s train. Unfortunately, line 20 in the gadget is quite long, so it’s not immediately clear where exactly the syntax checker encounters an error. (The code should be valid, it’s emitted by webpack and was working previously.) --- Summary so far: reduced to `(a=1,2)`; worked around in AC/DC; no other gadget likely to be affected; [upstream #65](https://github.com/mck89/peast/issues/65); fixed in Peast 0.16, to be deployed with 1.42.0-wmf.14.