I noticed the following issues while reviewing the different user flows in Jade.
[*] UI1. When I try to endorse a proposal that I have already endorsed, I get this error: "Could not find a proposal with matching "data" ''$1''" There should be an error that tells me I have already endorsed the proposal.
[] UI2. I can add an endorsement to two different proposals. I should not be able to endorse two different proposals. Either this should throw an error or it should move my endorsement from the old proposal to the new one. I'm partial to throwing an error.
[] UI3. The comment that is left when I delete a proposal starts with "jade-deleteproposal|0". Is 0 an internal identifier? If so, we could probably drop that from the comment. I'm sure at one point I thought it was necessary but I don't think it makes sense anymore.
[] UI4. "Propose a new label" button should be progressive blue when there are no proposed labels for the facet.
[] UI5. We should indicate that the user should wait somehow when performing an API action behind the UI. Maybe we could just disable the button that a user clicked while the action is happening.
[] UI6. When I try to move an endorsement and click "Endorse label" in the pop-over dialog, nothing happens. I get the following error in my console: "Cannot read property 'setLabel' of undefined at OoUiButtonInputWidget.MoveEndorsementDialog.onSubmitButtonClick" -- Upon review, this only seems to happen when I have endorsed multiple labels which should be impossible. So fixing UI2 might resolve this.
[] UI7. I should not have the option of moving other people's endorsements. It would be best if the endorsement menu had that option disabled for all but my my own endorsements.
[*] UI8. Add new help text to Edit Quality popup