Change Details

Currently, ResourceLoader modules use global object variables such as $wgUser and $wgLang; they should rather get them from a context object (maybe integrated in ResourceLoaderContext?) ---- * ResourceLoader.php: * [ ] `$wgShowExceptionDetails` in static `formatException()`. * [ ] `$wgResourceLoaderDebug` and `$wgRequest` in static `inDebugMode()`. * [ ] Call to `OutputPage::transformCssMedia()`, which in turn uses `$wgRequest`. * [x] ResourceLoaderContext.php * [x] `$wgLanguageCode` in `getLanguage()` as fallback. * [ ] ResourceLoaderFileModule.php: `$IP`, `$wgResourceBasePath`, `$wgExtensionAssetsPath`. * [ ] ResourceLoaderImage.php: `$wgSVGConverter`, `$wgSVGConverterPath`. * [x] ResourceLoaderModule.php: `$wgContLang` in `getFlip()`. * ResourceLoaderStartUpModule.php: * [x] `$wgContLang` in `getConfigSettings()`. * [ ] `$wgIncludeLegacyJavaScript` in `getLegacyModules()`. - T130879

Currently, ResourceLoader modules use global config variables; they should rather get them from the local Config object. ---- * ResourceLoader.php: * [ ] `$wgShowExceptionDetails` in static `formatException()`. * [ ] `$wgResourceLoaderDebug` and `$wgRequest` in static `inDebugMode()`. * [ ] Call to `OutputPage::transformCssMedia()`, which in turn uses `$wgRequest`. * [x] ResourceLoaderContext.php * [x] `$wgLanguageCode` in `getLanguage()` as fallback. * [ ] ResourceLoaderFileModule.php: `$IP`, `$wgResourceBasePath`, `$wgExtensionAssetsPath`. * [ ] ResourceLoaderImage.php: `$wgSVGConverter`, `$wgSVGConverterPath`. * [x] ResourceLoaderModule.php: `$wgContLang` in `getFlip()`. * ResourceLoaderStartUpModule.php: * [x] `$wgContLang` in `getConfigSettings()`. * [ ] `$wgIncludeLegacyJavaScript` in `getLegacyModules()`. - T130879

Currently, ResourceLoader modules use global objectconfig variables such as $wgUser and $wgLang;s; they should rather get them from a context object (maybe integrated in ResourceLoaderContext?)the local Config object. ---- * ResourceLoader.php: * [ ] `$wgShowExceptionDetails` in static `formatException()`. * [ ] `$wgResourceLoaderDebug` and `$wgRequest` in static `inDebugMode()`. * [ ] Call to `OutputPage::transformCssMedia()`, which in turn uses `$wgRequest`. * [x] ResourceLoaderContext.php * [x] `$wgLanguageCode` in `getLanguage()` as fallback. * [ ] ResourceLoaderFileModule.php: `$IP`, `$wgResourceBasePath`, `$wgExtensionAssetsPath`. * [ ] ResourceLoaderImage.php: `$wgSVGConverter`, `$wgSVGConverterPath`. * [x] ResourceLoaderModule.php: `$wgContLang` in `getFlip()`. * ResourceLoaderStartUpModule.php: * [x] `$wgContLang` in `getConfigSettings()`. * [ ] `$wgIncludeLegacyJavaScript` in `getLegacyModules()`. - T130879