Change Details

New regression in wmf.5. This will likely trigger error logging tomorrow. If you are logged in and click the desktop link we showed a AMC drawer like so (note that the "No thanks" and enabled button are pressed together - likely a longstanding issue from our move to Codex). We didn't catch this in development as it's hard to test this workflow and we don't have any tests covering it. {F41509387} This is no longer working on group 1 wikis (flagged by error reporting) This looks related to the work we did to restrict our unstable APIs from gadgets/extensions. We should either remove this feature, or fix it. # TODO [] Fix the immediate issue [] Correct the design. [] Add some tests for catching regressions to this component in future since it is hard to test. # Production error Error: TypeError: Cannot read properties of undefined (reading 'loadCampaign') ``` t HTMLAnchorElement.amcDesktopClickHandler https://m.mediawiki.org/w/load.php?lang=en&modules=skins.minerva.scripts&skin=minerva&version=sffel:42:689 at HTMLAnchorElement.dispatch https://m.mediawiki.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=minerva&version=1oirs:376:932 at elemData.handle https://m.mediawiki.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=minerva&version=1oirs:373:565 ``` # QA steps - Login and make sure AMC is disabled - Click desktop link in footer at bottom of page - Expected: the drawer should show.

New regression in wmf.5. This will likely trigger error logging tomorrow. If you are logged in and click the desktop link we showed a AMC drawer like so (note that the "No thanks" and enabled button are pressed together - likely a longstanding issue from our move to Codex). We didn't catch this in development as it's hard to test this workflow and we don't have any tests covering it. {F41509387} This is no longer working on group 1 wikis (flagged by error reporting) This looks related to the work we did to restrict our unstable APIs from gadgets/extensions. We should either remove this feature, or fix it. # TODO [] Fix the immediate issue [] Correct the design. [] Add some tests for catching regressions to this component in future since it is hard to test. [] It should be possible to scroll the entire drawer. It shouldn't be clipped at the bottom. # Developer notes The following is needed for testing: ``` $wgMFAmcOutreachMinEditCount = 0; $wgMFAmcOutreach = true; ``` # Production error Error: TypeError: Cannot read properties of undefined (reading 'loadCampaign') ``` t HTMLAnchorElement.amcDesktopClickHandler https://m.mediawiki.org/w/load.php?lang=en&modules=skins.minerva.scripts&skin=minerva&version=sffel:42:689 at HTMLAnchorElement.dispatch https://m.mediawiki.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=minerva&version=1oirs:376:932 at elemData.handle https://m.mediawiki.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=minerva&version=1oirs:373:565 ``` # QA steps - Login and make sure AMC is disabled - Click desktop link in footer at bottom of page - Expected: the drawer should show.

New regression in wmf.5. This will likely trigger error logging tomorrow. If you are logged in and click the desktop link we showed a AMC drawer like so (note that the "No thanks" and enabled button are pressed together - likely a longstanding issue from our move to Codex). We didn't catch this in development as it's hard to test this workflow and we don't have any tests covering it. {F41509387} This is no longer working on group 1 wikis (flagged by error reporting) This looks related to the work we did to restrict our unstable APIs from gadgets/extensions. We should either remove this feature, or fix it. # TODO [] Fix the immediate issue [] Correct the design. [] Add some tests for catching regressions to this component in future since it is hard to test. [] It should be possible to scroll the entire drawer. It shouldn't be clipped at the bottom. # Developer notes The following is needed for testing: ``` $wgMFAmcOutreachMinEditCount = 0; $wgMFAmcOutreach = true; ``` # Production error Error: TypeError: Cannot read properties of undefined (reading 'loadCampaign') ``` t HTMLAnchorElement.amcDesktopClickHandler https://m.mediawiki.org/w/load.php?lang=en&modules=skins.minerva.scripts&skin=minerva&version=sffel:42:689 at HTMLAnchorElement.dispatch https://m.mediawiki.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=minerva&version=1oirs:376:932 at elemData.handle https://m.mediawiki.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=minerva&version=1oirs:373:565 ``` # QA steps - Login and make sure AMC is disabled - Click desktop link in footer at bottom of page - Expected: the drawer should show.