Change Details

- Go to fr.wikipedia.org, the sidebar menu should be open - Click hamburger icon to hide the sidebar. - Confirm a preference is saved to the API - Hard refresh the page Expected: sidebar is still hidden Actual: sidebar is open # Developer notes SkinVector::isSidebarVisible alway seems to return false. I believe we (I) broke the registration of the preference in onGetPreferences in I7454d8f1cfdef81e7f3df476d8ce86736b46fff2 Probably worth adding a UI regression test for this.

- Go to fr.wikipedia.org, the sidebar menu should be open - Click hamburger icon to hide the sidebar. - Confirm a preference is saved to the API - Hard refresh the page Expected: sidebar is still hidden Actual: sidebar is open # Developer notes SkinVector::isSidebarVisible alway seems to return false. I believe we (I) broke the registration of the preference in onGetPreferences in [[ https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/755813/24/includes/Hooks.php | I7454d8f1cfdef81e7f3df476d8ce86736b46fff2 ]] Probably worth adding a UI regression test for this.

- Go to fr.wikipedia.org, the sidebar menu should be open - Click hamburger icon to hide the sidebar. - Confirm a preference is saved to the API - Hard refresh the page Expected: sidebar is still hidden Actual: sidebar is open # Developer notes SkinVector::isSidebarVisible alway seems to return false. I believe we (I) broke the registration of the preference in onGetPreferences in I7454d8f1cfdef81e7f3df476d8ce86736b46fff2[[ https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/755813/24/includes/Hooks.php | I7454d8f1cfdef81e7f3df476d8ce86736b46fff2 ]] Probably worth adding a UI regression test for this.