Change Details

LinkCache::addGoodLinkObj() has many optional arguments, but omitting them actually means corrupting the cache. Production code should never call this method, it should use addGoodLinkObjFromRow instead. addGoodLinkObj() is kind of handy to have for tests. We should introduce a separate method, addGoodLinkObjForTest(), that can only be used of MW_PHPUNIT_TEST is set. addGoodLinkObj() is used in six extensions, see https://codesearch.wmcloud.org/extensions/?q=-%3EaddGoodLinkObj%5C(&i=nope&files=&excludeFiles=&repos= Deployed: [x] CirrusSearch [] Babel [x] Flow [x] GeoData [x] Wikibase Other: [] Favorites (beta)

LinkCache::addGoodLinkObj() has many optional arguments, but omitting them actually means corrupting the cache. Production code should never call this method, it should use addGoodLinkObjFromRow instead. addGoodLinkObj() is kind of handy to have for tests. We should introduce a separate method, addGoodLinkObjForTest(), that can only be used of MW_PHPUNIT_TEST is set. addGoodLinkObj() is used in six extensions, see https://codesearch.wmcloud.org/extensions/?q=-%3EaddGoodLinkObj%5C(&i=nope&files=&excludeFiles=&repos= Deployed: [x] CirrusSearch [x] Babel [x] Flow [x] GeoData [x] Wikibase Other: [] Favorites (beta)

LinkCache::addGoodLinkObj() has many optional arguments, but omitting them actually means corrupting the cache. Production code should never call this method, it should use addGoodLinkObjFromRow instead. addGoodLinkObj() is kind of handy to have for tests. We should introduce a separate method, addGoodLinkObjForTest(), that can only be used of MW_PHPUNIT_TEST is set. addGoodLinkObj() is used in six extensions, see https://codesearch.wmcloud.org/extensions/?q=-%3EaddGoodLinkObj%5C(&i=nope&files=&excludeFiles=&repos= Deployed: [x] CirrusSearch [x] Babel [x] Flow [x] GeoData [x] Wikibase Other: [] Favorites (beta)