Change Details

Using the ::class name resolution feature for the `$maintClass` variable in maintenance script would be a nice code improvement and allows to validate the line with phan. ``` $maintClass = "DeleteInactiveNewsletters"; ``` better: ``` $maintClass = DeleteInactiveNewsletters::class; ``` Without the need of `\Namespace`, because it is always in the same namespace as the file. https://codesearch.wmcloud.org/search/?q=%5C%24maintClass%5Cs*%3D%5Cs*%5B%5Ea-zA-Z%5D&i=nope&files=&excludeFiles=&repos= Example patch set: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Newsletter/+/494026 Should be detected by a linter like codesniffer or phan? (when using phan, maybe could be resolved together with T234749)

Using the ::class name resolution feature for the `$maintClass` variable in maintenance script would be a nice code improvement and allows to validate the line with phan. ``` $maintClass = "DeleteInactiveNewsletters"; ``` better: ``` $maintClass = DeleteInactiveNewsletters::class; ``` Without the need of `\Namespace`, because it is always in the same namespace as the file. https://codesearch.wmcloud.org/search/?q=%5C%24maintClass%5Cs*%3D%5Cs*%5B%5Ea-zA-Z%5Cs%5D&i=nope&files=&excludeFiles=&repos= Example patch set: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Newsletter/+/494026 Should be detected by a linter like codesniffer or phan? (when using phan, maybe could be resolved together with T234749)

Using the ::class name resolution feature for the `$maintClass` variable in maintenance script would be a nice code improvement and allows to validate the line with phan. ``` $maintClass = "DeleteInactiveNewsletters"; ``` better: ``` $maintClass = DeleteInactiveNewsletters::class; ``` Without the need of `\Namespace`, because it is always in the same namespace as the file. https://codesearch.wmcloud.org/search/?q=%5C%24maintClass%5Cs*%3D%5Cs*%5B%5Ea-zA-Z%5Cs%5D&i=nope&files=&excludeFiles=&repos= Example patch set: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Newsletter/+/494026 Should be detected by a linter like codesniffer or phan? (when using phan, maybe could be resolved together with T234749)