Change Details

== Background The new user menu is misaligned on bnwiki == Steps to reproduce Go to https://bn.wikipedia.org/wiki/%E0%A6%AA%E0%A7%8D%E0%A6%B0%E0%A6%A7%E0%A6%BE%E0%A6%A8_%E0%A6%AA%E0%A6%BE%E0%A6%A4%E0%A6%BE?vectoruserlinks=1&useskinversion=2&uselang=bn as a logged-in users (bug also happens when logged-out) == Observed {F34589489} == Expected User menu should be aligned with other icons == Developer notes This appears to relate to rules in MediaWiki core relating to font-sizes in certain languages: https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.skinning/i18n-headings.less#L49 These rules should be scoped to the article content area and not apply to headings outside the content e.g. `.mw-body-content` line-height: 1.4em; Related to T285972

== Background The new user menu is misaligned on bnwiki == Steps to reproduce Go to https://bn.wikipedia.org/wiki/%E0%A6%AA%E0%A7%8D%E0%A6%B0%E0%A6%A7%E0%A6%BE%E0%A6%A8_%E0%A6%AA%E0%A6%BE%E0%A6%A4%E0%A6%BE?vectoruserlinks=1&useskinversion=2&uselang=bn as a logged-in users (bug also happens when logged-out) == Observed {F34589489} == Expected User menu should be aligned with other icons == Developer notes == Option 1 (suggested) Override line height to 0 for the heading in this context. == Option 2 (rejected as significant work/risk) Don't use h3 in usermenu. Requires refactoring of menu code == Option 3 (rejected as the line height rules should apply to headings in sidebar) This appears to relate to rules in MediaWiki core relating to font-sizes in certain languages: https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.skinning/i18n-headings.less#L49 These rules should be scoped to the article content area and not apply to headings outside the content e.g. `.mw-body-content` line-height: 1.4em; Related to T285972

== Background The new user menu is misaligned on bnwiki == Steps to reproduce Go to https://bn.wikipedia.org/wiki/%E0%A6%AA%E0%A7%8D%E0%A6%B0%E0%A6%A7%E0%A6%BE%E0%A6%A8_%E0%A6%AA%E0%A6%BE%E0%A6%A4%E0%A6%BE?vectoruserlinks=1&useskinversion=2&uselang=bn as a logged-in users (bug also happens when logged-out) == Observed {F34589489} == Expected User menu should be aligned with other icons == Developer notes == Option 1 (suggested) Override line height to 0 for the heading in this context. == Option 2 (rejected as significant work/risk) Don't use h3 in usermenu. Requires refactoring of menu code == Option 3 (rejected as the line height rules should apply to headings in sidebar) This appears to relate to rules in MediaWiki core relating to font-sizes in certain languages: https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.skinning/i18n-headings.less#L49 These rules should be scoped to the article content area and not apply to headings outside the content e.g. `.mw-body-content` line-height: 1.4em; Related to T285972