Change Details

As noted a number of times (e.g. T212948), 'sent' (or 'sent to partner') is becoming a misnomer for the final status of an application on the Library Card platform. Of all our distribution workflows, it really only applies to the `EMAIL` distribution method. For access codes, proxy, and links, we don't send anything to the partner, and in fact approving an application marks it as 'sent' immediately. Ideally we should rename both strings and variables from 'sent' to 'finalised'. In the `EMAIL` distribution method case, we could still show users the 'sent to partner' text, and show 'finalized' or simply stick with 'approved' otherwise.