Code relating to the toggle code currently lives in mobile.mediaViewer and we will move it to webpack.
Similar to the language feature it is lazy loaded thus its essential we've worked out a strategy before taking on this task.
= Precursors
[x] T210210 is completed
= Acceptance criteria
[x] code for mobile.mediaViewer module compiled in webpack
[x] code for mobile.mediaViewer is not loaded on the critical path - it is delayed until an image is clicked (see also T210210)
x[] critical js size (mobile.startup.js + mobile.common.js) has not increased. Beware of any modules that are shared among the lazy loaded chunks and are not in mobile.startup.js. Webpack will excise these into mobile.common.js and increase our critical js size.
[x] tests are ported to node-qunit
[x] Minerva is retained in a mergeable state throughout the migration. No need to worry about cached html but an alias module (empty module with mobile.startup dependency) will be needed until references in Minerva have been updated.
Code:
* https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/tree/master/resources/mobile.mediaViewer
= Sign off steps
[x ] [[ https://www.mediawiki.org/wiki/Reading/Web/Projects/Invest_in_the_MobileFrontend_%26_MinervaNeue_frontend_architecture/Progress?useskin=vector | Progress ]] is updated.
[x] Make a new card for porting mobile.notifications.overlay to webpack.
[x] Make a new card for porting mobile.category.overlay to webpack
[x] Make a new card for porting mobile.talk.overlays to webpack