Setting up the new [[ https://civicrm.wikimedia.org/civicrm/dr/donorfind | DR Donor Find ]] SK/FB using the new SK sub search feature, which has just been added to core, I noticed a few areas that are buggy or could use improvement:
# Pagination for subsearches: the current options (no pagination, pagination that takes up an enormous amount of space) are unsatifying. Add styling to show minimal pagination, perhaps just tiny back and forward arrows and a total count.
# Alignment of subsearches is difficult to parse visually because they are vertically centered, experiment with vertical top-alignment to see if it is more visible. At the same time, remove the drop shadow to reduce visual clutter.
# [[ https://lab.civicrm.org/dev/core/-/work_items/6551 | Gitlab issue ]]: Subsearches should have `Inherit from parent` Header option to control when they are refreshed. Currently you can either set them to `Auto-run` which results in constant refreshing when changing filters or `Search Button` which adds an undesirable large button that you need to click. Neither is right for sub searches when the parent search has `Search Button`.
# DONE If header row in a SearchDisplay has no text and no sort arrows, hide it entirely (this would apply in all cases, but for sub searches it would save precious space).
# The autocomplete when selecting a sub search in a parent SD doesn't seem to find expected SD options. Expectation is that entering a word would show all the options that include that word, but actual result is only matching titles that start with that word. This is because of the includeWildCardInName setting, which sets if the autocomplete uses %searchterm% or searchterm%. Would be nice to refine this setting so we can use it for quicksearch and similar without this kind of unintended effect.
# In FormBuilder, it should be possible to apply a filter to a specific sub search (e.g. filter contributions shown for a contact by date range). Once this is done, update the DR Donor Find SK to remove hardcoded filters, replacing with FB filters.
# No strictly sub search related, but the available buttons for Recurring Contributions should include View (currently only Update and Delete). Presumbly this is because the page route currently requires cid, but it could be updated so it doesn't.
# No strictly sub search related, but FormBuilder shows an overly tall box for checkboxes when there are only 2 options:
{F80105379}
# Not strictly sub search related, but the select for the operator in FormBuilder should be less wide. At the same time, it would be nice to make the same field in API4 explorer a little wider, so both are the same and somewhere in between the two current extremes. And while in there, it would help to make the fields for selecting / viewing field names wider, so field labels aren't cut off (especially with implicit joins that can make them very long). In FB, allow the user to specify a class for the value field (maybe just small (amounts), normal and large for fields that need more space, like email, street address). Set reasonable defaults based on field type.
{F80058996}
# The gear icon on a FormBuilder that lets you edit the SKs should also include embedded searches as options.