Change Details

FenParser0x88 has an incredibly high CRAP at 142,000! (was: 224,000) This should be on the order of 10e0. The following functions are the worst offenders [] getValidMovesAndResult() - CRAP: 11k [] getFromAndToByNotation() - CRAP: 1.9k [] getValidSquaresOnCheck() - CRAP: 0.7k (was: 1.0k) [] getCaptureAndProtectiveMoves() - CRAP: 0.7k [] getNotationForAMove() - CRAP: 0.7k They can be fixed by writing tests and refactoring. See https://doc.wikimedia.org/cover-extensions/ChessBrowser/index.html

FenParser0x88 has an incredibly high CRAP at 121,000! (was: 224,000) This should be on the order of 10e0. The following functions are the worst offenders [] getValidMovesAndResult() - CRAP: 11k [] getFromAndToByNotation() - CRAP: 1.9k [] getValidSquaresOnCheck() - CRAP: 0.7k (was: 1.0k) [] getCaptureAndProtectiveMoves() - CRAP: 0.7k [] getNotationForAMove() - CRAP: 0.7k They can be fixed by writing tests and refactoring. See https://doc.wikimedia.org/cover-extensions/ChessBrowser/index.html

FenParser0x88 has an incredibly high CRAP at 142121,000! (was: 224,000) This should be on the order of 10e0. The following functions are the worst offenders [] getValidMovesAndResult() - CRAP: 11k [] getFromAndToByNotation() - CRAP: 1.9k [] getValidSquaresOnCheck() - CRAP: 0.7k (was: 1.0k) [] getCaptureAndProtectiveMoves() - CRAP: 0.7k [] getNotationForAMove() - CRAP: 0.7k They can be fixed by writing tests and refactoring. See https://doc.wikimedia.org/cover-extensions/ChessBrowser/index.html