Change Details

Since Version 1.27 function `LoginForm::getLoginToken()` returns a `MediaWiki\Session\Token` instead of a string. Function `chooseName()` in file `SpecialOpenIDLogin.body.php` currently tests against a string: ``` if ( LoginForm::getLoginToken() != $wgRequest->getVal( 'openidChooseNameBeforeLoginToken' ) ) { ``` This should be altered to something like ``` if ( false === LoginForm::getLoginToken()->match($wgRequest->getVal( 'openidChooseNameBeforeLoginToken' ) ) ) { ```

Since Version 1.27 function `LoginForm::getLoginToken()` returns a `MediaWiki\Session\Token` instead of a string. Function `chooseName()` in file `SpecialOpenIDLogin.body.php` currently tests against a string: ``` if ( LoginForm::getLoginToken() != $wgRequest->getVal( 'openidChooseNameBeforeLoginToken' ) ) { ``` This should be altered to something like ``` if ( false === LoginForm::getLoginToken()->match($wgRequest->getVal( 'openidChooseNameBeforeLoginToken' ) ) ) { ``` `User::setNewPassword()` now always throws exceptions, so this also needs to be addressed.

Since Version 1.27 function `LoginForm::getLoginToken()` returns a `MediaWiki\Session\Token` instead of a string. Function `chooseName()` in file `SpecialOpenIDLogin.body.php` currently tests against a string: ``` if ( LoginForm::getLoginToken() != $wgRequest->getVal( 'openidChooseNameBeforeLoginToken' ) ) { ``` This should be altered to something like ``` if ( false === LoginForm::getLoginToken()->match($wgRequest->getVal( 'openidChooseNameBeforeLoginToken' ) ) ) { ``` `User::setNewPassword()` now always throws exceptions, so this also needs to be addressed.