Change Details

This will be another change to repo/WikibaseRepo.FederatedProperties.entitytypes.php The service should be constructed in our ApiServiceFactory class and retrieve from there. Once this is done no visible change will happen when formatting entities. I believe that you might be able to see the label if you comment out the following 2 lines in lib/includes/Formatters/LabelsProviderEntityIdHtmlLinkFormatter.php as a test (dont commit this commented out) ``` public function formatEntityId( EntityId $entityId ) { $title = $this->entityTitleLookup->getTitleForId( $entityId ); // if ( $title === null ) { // return $this->nonExistingFormatter->formatEntityId( $entityId ); // } $term = $this->lookupEntityLabel( $entityId ); ```

This will be another change to repo/WikibaseRepo.FederatedProperties.entitytypes.php The service should be constructed in our ApiServiceFactory class and retrieve from there. Once this is done no visible change will happen when formatting entities. I believe that you might be able to see the label if you comment out the following 2 lines in lib/includes/Formatters/LabelsProviderEntityIdHtmlLinkFormatter.php as a test (dont commit this commented out) ``` $title = $this->entityTitleLookup->getTitleForId( $entityId ); // if ( $title === null ) { // return $this->nonExistingFormatter->formatEntityId( $entityId ); // } $term = $this->lookupEntityLabel( $entityId ); // We can skip the potentially expensive isKnown() check if we found a term. if ( $term !== null ) { $label = $term->getText(); // } elseif ( !$title->isKnown() ) { // return $this->nonExistingFormatter->formatEntityId( $entityId ); } else { $label = $entityId->getSerialization(); } ```

This will be another change to repo/WikibaseRepo.FederatedProperties.entitytypes.php The service should be constructed in our ApiServiceFactory class and retrieve from there. Once this is done no visible change will happen when formatting entities. I believe that you might be able to see the label if you comment out the following 2 lines in lib/includes/Formatters/LabelsProviderEntityIdHtmlLinkFormatter.php as a test (dont commit this commented out) ``` public function formatEntityId( EntityId $entityId ) { $title = $this->entityTitleLookup->getTitleForId( $entityId ); // if ( $title === null ) { // return $this->nonExistingFormatter->formatEntityId( $entityId ); // } $term = $this->lookupEntityLabel( $entityId ); // We can skip the potentially expensive isKnown() check if we found a term. if ( $term !== null ) { $label = $term->getText(); // } elseif ( !$title->isKnown() ) { // return $this->nonExistingFormatter->formatEntityId( $entityId ); } else { $label = $entityId->getSerialization(); } ```