Change Details

The [[ https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/resources/skins.minerva.scripts/DownloadIcon.js#L52 | DownloadIcon ]] and [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/461008/7/resources/skins.minerva.share/ShareIcon.js | ShareIcon ]] in Minerva extend the Icon class to override some of its options, however when rendered it looks and quacks like an Icon.js. Let's rewrite Icon.js and these files so they use composition rather than inheritance. == Acceptance criteria [] Armed with the ability to define events in props and [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/469536/ | experiments with factory functions ]] we should be able to rewrite DownloadIcon as a factory functions that return instances of an Icon class. [] The same should be possible for the ShareIcon [] Be prepared to report back to the team on your experiences.

The [[ https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/resources/skins.minerva.scripts/DownloadIcon.js#L52 | DownloadIcon ]] and [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/461008/7/resources/skins.minerva.share/ShareIcon.js | ShareIcon ]] in Minerva extend the Icon class to override some of its options, however when rendered it looks and quacks like an Icon.js. Let's rewrite Icon.js and these files so they use composition rather than inheritance. == Acceptance criteria [x] Armed with the ability to define events in props and [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/469536/ | experiments with factory functions ]] we should be able to rewrite DownloadIcon as a factory functions that return instances of an Icon class. [] The same should be possible for the ShareIcon [] Be prepared to report back to the team on your experiences.

The [[ https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/resources/skins.minerva.scripts/DownloadIcon.js#L52 | DownloadIcon ]] and [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/461008/7/resources/skins.minerva.share/ShareIcon.js | ShareIcon ]] in Minerva extend the Icon class to override some of its options, however when rendered it looks and quacks like an Icon.js. Let's rewrite Icon.js and these files so they use composition rather than inheritance. == Acceptance criteria [x] Armed with the ability to define events in props and [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/469536/ | experiments with factory functions ]] we should be able to rewrite DownloadIcon as a factory functions that return instances of an Icon class. [] The same should be possible for the ShareIcon [] Be prepared to report back to the team on your experiences.