Change Details

**Steps to reproduce** REL1_25 * go to https://gerrit.wikimedia.org/r/#/c/289880/ REL1_26 * go to https://gerrit.wikimedia.org/r/#/c/267827/ * scroll to bottom where you see the tests failures. * Select any one for example this one https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-trusty/688/console and https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-trusty/744/console **Actual results** REL1_25 * tests are failing with 18:15:11 There were 2 errors: 18:15:11 18:15:11 1) ApiLoginTest::testApiLoginBadPass 18:15:11 Trying to destroy uninitialized session 18:15:11 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/GlobalFunctions.php:3461 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3574 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3556 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/includes/api/ApiLoginTest.php:26 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/MediaWikiTestCase.php:131 18:15:11 18:15:11 2) ApiLoginTest::testApiLoginGoodPass 18:15:11 Trying to destroy uninitialized session 18:15:11 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/GlobalFunctions.php:3461 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3574 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3556 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/includes/api/ApiLoginTest.php:71 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/MediaWikiTestCase.php:131 REL1_26 15:08:21 There were 2 errors: 15:08:21 15:08:21 1) ApiLoginTest::testApiLoginBadPass 15:08:21 Trying to destroy uninitialized session 15:08:21 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/GlobalFunctions.php:3473 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3639 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3621 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/includes/api/ApiLoginTest.php:26 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/MediaWikiTestCase.php:131 15:08:21 15:08:21 2) ApiLoginTest::testApiLoginGoodPass 15:08:21 Trying to destroy uninitialized session 15:08:21 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/GlobalFunctions.php:3473 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3639 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3621 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/includes/api/ApiLoginTest.php:71 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/MediaWikiTestCase.php:131 **Expected results** The tests should pass without failure. I think this https://phabricator.wikimedia.org/diffusion/MW/browse/REL1_25/tests/phpunit/includes/api/ApiLoginTest.php may have broken the tests but I'm not sure.

**Steps to reproduce** REL1_25 * go to https://gerrit.wikimedia.org/r/#/c/289880/ REL1_26 * go to https://gerrit.wikimedia.org/r/#/c/267827/ * scroll to bottom where you see the tests failures. * Select any one for example this one https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-trusty/688/console and https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-trusty/744/console **Actual results** REL1_25 * tests are failing with 18:15:11 There were 2 errors: 18:15:11 18:15:11 1) ApiLoginTest::testApiLoginBadPass 18:15:11 Trying to destroy uninitialized session 18:15:11 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/GlobalFunctions.php:3461 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3574 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3556 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/includes/api/ApiLoginTest.php:26 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/MediaWikiTestCase.php:131 18:15:11 18:15:11 2) ApiLoginTest::testApiLoginGoodPass 18:15:11 Trying to destroy uninitialized session 18:15:11 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/GlobalFunctions.php:3461 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3574 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3556 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/includes/api/ApiLoginTest.php:71 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/MediaWikiTestCase.php:131 REL1_26 15:08:21 There were 2 errors: 15:08:21 15:08:21 1) ApiLoginTest::testApiLoginBadPass 15:08:21 Trying to destroy uninitialized session 15:08:21 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/GlobalFunctions.php:3473 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3639 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3621 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/includes/api/ApiLoginTest.php:26 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/MediaWikiTestCase.php:131 15:08:21 15:08:21 2) ApiLoginTest::testApiLoginGoodPass 15:08:21 Trying to destroy uninitialized session 15:08:21 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/GlobalFunctions.php:3473 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3639 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3621 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/includes/api/ApiLoginTest.php:71 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/MediaWikiTestCase.php:131 **Expected results** The tests should pass without failure. I think this https://phabricator.wikimedia.org/rMWdfd1256837ef7b259880b6cd470ce17487ac9379 may have broken the tests but I'm not sure.

**Steps to reproduce** REL1_25 * go to https://gerrit.wikimedia.org/r/#/c/289880/ REL1_26 * go to https://gerrit.wikimedia.org/r/#/c/267827/ * scroll to bottom where you see the tests failures. * Select any one for example this one https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-trusty/688/console and https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-trusty/744/console **Actual results** REL1_25 * tests are failing with 18:15:11 There were 2 errors: 18:15:11 18:15:11 1) ApiLoginTest::testApiLoginBadPass 18:15:11 Trying to destroy uninitialized session 18:15:11 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/GlobalFunctions.php:3461 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3574 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3556 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/includes/api/ApiLoginTest.php:26 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/MediaWikiTestCase.php:131 18:15:11 18:15:11 2) ApiLoginTest::testApiLoginGoodPass 18:15:11 Trying to destroy uninitialized session 18:15:11 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/GlobalFunctions.php:3461 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3574 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3556 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/includes/api/ApiLoginTest.php:71 18:15:11 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/MediaWikiTestCase.php:131 REL1_26 15:08:21 There were 2 errors: 15:08:21 15:08:21 1) ApiLoginTest::testApiLoginBadPass 15:08:21 Trying to destroy uninitialized session 15:08:21 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/GlobalFunctions.php:3473 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3639 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3621 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/includes/api/ApiLoginTest.php:26 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/MediaWikiTestCase.php:131 15:08:21 15:08:21 2) ApiLoginTest::testApiLoginGoodPass 15:08:21 Trying to destroy uninitialized session 15:08:21 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/GlobalFunctions.php:3473 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3639 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/includes/User.php:3621 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/includes/api/ApiLoginTest.php:71 15:08:21 /home/jenkins/workspace/mediawiki-phpunit-hhvm-trusty/src/tests/phpunit/MediaWikiTestCase.php:131 **Expected results** The tests should pass without failure. I think this https://phabricator.wikimedia.org/diffusion/MW/browse/REL1_25/tests/phpunit/includes/api/ApiLoginTest.phprMWdfd1256837ef7b259880b6cd470ce17487ac9379 may have broken the tests but I'm not sure.