Change Details

#### Description //(Please provide the context of the performance review, and describe how the feature or service works at a high level technically and from a user point of view, or link to documentation describing that.)// #### Preview environment //(Insert one or more links to where the feature can be tested, e.g. on Beta Cluster.)// Hosting the changes on Beta Cluster is a requirement prior to performance review. Please ensure that the feature can be used directly on the link(s) provided, without any data entry such as having to create an article. Any sample content needed should already be present. If the changes cannot be hosted on Beta Cluster, explain why and provide links to an alternate public environment instead where the Performance Team can also SSH into. Links to code only is insufficient for a performance review. #### Which code to review //(Provide links to all proposed changes and/or repositories. It should also describe changes which have not yet been merged or deployed but are planned prior to deployment. E.g. production Puppet, wmf config, or in-flight features expected to complete prior to launch date, etc.).// #### Performance assessment Please initiate the performance assessment by answering the below: - What work has been done to ensure the best possible performance of the feature? - What are likely to be the weak areas (e.g. bottlenecks) of the code in terms of performance? - Are there potential optimisations that haven't been performed yet? - Please list which performance measurements are in place for the feature and/or what you've measured ad-hoc so far. If you are unsure what to measure, ask the Performance Team for advice: [[ mailto:performance-team@wikimedia.org | performance-team@wikimedia.org ]].

#### Description As part of the work CheckUser improvements, the tool now allows to search for multiple targets, and retrieve large sets of data. There has been extensive work done to make sure that these queries are performant. [@tchan: Add previous tickets about the SQL queries and the plans] #### Preview environment Because of the sensitive nature of CheckUser, the tool is only available in limited spaces, and to limited number of people. Preview is even more limited; At the moment the new CheckUser queries are available on testwiki and only for users with the `staff` right: https://test.wikipedia.org/wiki/Special:Investigate [@Niharika do we have test users we can provide for an initial query?] #### Which code to review [@tchan @dmaza @dbarrat can you add the gerrit patches that are relevant to the SQL queries for the Compare tab?] #### Performance assessment Please initiate the performance assessment by answering the below: - What work has been done to ensure the best possible performance of the feature? - What are likely to be the weak areas (e.g. bottlenecks) of the code in terms of performance? - Are there potential optimisations that haven't been performed yet? - Please list which performance measurements are in place for the feature and/or what you've measured ad-hoc so far. If you are unsure what to measure, ask the Performance Team for advice: [[ mailto:performance-team@wikimedia.org | performance-team@wikimedia.org ]].

#### Description //(Please provideAs part of the context of the performance reviewwork CheckUser improvements, and describe how the feature or service works at a high level technically and from a user point of viewthe tool now allows to search for multiple targets, or link to documentation describing that.)//and retrieve large sets of data. There has been extensive work done to make sure that these queries are performant. #### Preview environment[@tchan: Add previous tickets about the SQL queries and the plans] //(Insert one or more links to where the feature can be tested, e.g. on Beta Cluster.)//#### Preview environment Hosting the changes on Beta Cluster is a requirement prior to performance review.Because of the sensitive nature of CheckUser, Please ensure that the feature can be used directly on the link(s) providedtool is only available in limited spaces, without any data entry such as having to create an articleand to limited number of people. Any sample content needed should already be present.Preview is even more limited; At the moment the new CheckUser queries are available on testwiki and only for users with the `staff` right: https://test.wikipedia.org/wiki/Special:Investigate If the changes cannot be hosted on Beta Cluster, explain why and provide links to an alternate public environment instead where the Performance Team can also SSH into. Links to code only is insufficient for a performance review.[@Niharika do we have test users we can provide for an initial query?] #### Which code to review //(Provide links to all proposed changes and/or repositories. It should also describe changes which have not yet been merged or deployed but are planned prior to deployment. E.g. production Puppet, wmf config, or in-flight features expected to complete prior to launch date, etc.).//[@tchan @dmaza @dbarrat can you add the gerrit patches that are relevant to the SQL queries for the Compare tab?] #### Performance assessment Please initiate the performance assessment by answering the below: - What work has been done to ensure the best possible performance of the feature? - What are likely to be the weak areas (e.g. bottlenecks) of the code in terms of performance? - Are there potential optimisations that haven't been performed yet? - Please list which performance measurements are in place for the feature and/or what you've measured ad-hoc so far. If you are unsure what to measure, ask the Performance Team for advice: [[ mailto:performance-team@wikimedia.org | performance-team@wikimedia.org ]].