Change Details

- [X] Ensure that `scap deploy` works from `deploy1002:/srv/deployment/phabricator/deployment` - [ ] `systemctl stop phd` prior to update, `systemctl start phd` afterwards. (//Does scap3 have hooks for this kind of thing?//) - [X] There are currently a `/srv/phab/libphutil` and `/srv/phab/libext/security` on phab1001. These are untracked and according to READMEs in both, I don't //think// they're doing anything, but we should make sure. - Going to take READMEs and repo contents at face value here. - Both have remote repos. - [ ] Symlink `/srv/phab/repos` to `/srv/repos` - [ ] Does anything actually use this? Config has `"repository.default-local-path": "/srv/repos"`... - [ ] Run storage migrations after code updates with `/usr/local/sbin/phab_deploy_finalize` - this is puppetized and should already be available on phab2001.

- [X] Ensure that `scap deploy` works from `deploy1002:/srv/deployment/phabricator/deployment` - [X] `systemctl stop phd` prior to update, `systemctl start phd` afterwards. (//Done in check script.//) - [X] There are currently a `/srv/phab/libphutil` and `/srv/phab/libext/security` on phab1001. These are untracked and according to READMEs in both, I don't //think// they're doing anything, but we should make sure. - Going to take READMEs and repo contents at face value here. - Both have remote repos. - [ ] Symlink `/srv/phab/repos` to `/srv/repos` - [ ] Does anything actually use this? Config has `"repository.default-local-path": "/srv/repos"`... Seems like no. - [ ] Run storage migrations after code updates with `/usr/local/sbin/phab_deploy_finalize` - this is puppetized and should already be available on phab2001. - [ ] Check that migrations are actually being run

- [X] Ensure that `scap deploy` works from `deploy1002:/srv/deployment/phabricator/deployment` - [ - [X] `systemctl stop phd` prior to update, `systemctl start phd` afterwards. (//Does scap3 have hooks for this kind of thing?ne in check script.//) - [X] There are currently a `/srv/phab/libphutil` and `/srv/phab/libext/security` on phab1001. These are untracked and according to READMEs in both, I don't //think// they're doing anything, but we should make sure. - Going to take READMEs and repo contents at face value here. - Both have remote repos. - [ ] Symlink `/srv/phab/repos` to `/srv/repos` - [ ] Does anything actually use this? Config has `"repository.default-local-path": "/srv/repos"`... Seems like no. - [ ] Run storage migrations after code updates with `/usr/local/sbin/phab_deploy_finalize` - this is puppetized and should already be available on phab2001. - [ ] Check that migrations are actually being run