Change Details

Looking through the code briefly, it looks like Popups conditionally loads the schema module that EL uses, but loads the ext.popups.eventlogging.js unconditionally and uses the functions defined there without any conditions as well. I'd suggest putting a check for the EventLogging library in front of the call to mw.eventLog.logEvent() in that file...at the very least. Hopefully avoid loading the file at all if EL is turned off. -------------------------- **Version**: unspecified **Severity**: normal

Looking through the code briefly, it looks like Popups conditionally loads the schema module that EL uses, but loads the ext.popups.eventlogging.js unconditionally and uses the functions defined there without any conditions as well. I'd suggest putting a check for the EventLogging library in front of the call to mw.eventLog.logEvent() in that file...at the very least. Hopefully avoid loading the file at all if EL is turned off.

Looking through the code briefly, it looks like Popups conditionally loads the schema module that EL uses, but loads the ext.popups.eventlogging.js unconditionally and uses the functions defined there without any conditions as well. I'd suggest putting a check for the EventLogging library in front of the call to mw.eventLog.logEvent() in that file...at the very least. Hopefully avoid loading the file at all if EL is turned off. -------------------------- **Version**: unspecified **Severity**: normal