Change Details

**Steps to reproduce** * Go to https://gerrit.wikimedia.org/r/#/c/274264/ * Type check experimental (Only if your whitelisted) Or you can just go to https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/4785/console **Actual results** * The test fails with this error 10:55:59 There was 1 error: 10:55:59 10:55:59 1) EchoEmailFormatterTest::testEmailFormatter 10:55:59 InvalidArgumentException: The icon is not registered 10:55:59 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/includes/formatters/NotificationFormatter.php:138 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/includes/EmailFormatter.php:175 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/includes/EmailFormatter.php:846 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/includes/EmailFormatter.php:733 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/includes/EmailFormatter.php:446 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/includes/EmailFormatter.php:87 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/tests/phpunit/EmailFormatterTest.php:53 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:147 10:55:59 10:55:59 -- 10:55:59 10:55:59 There was 1 failure: 10:55:59 10:55:59 1) Flow\Tests\Block\TopicListTest::testSortByOption 10:55:59 Default sortby now changed to updated 10:55:59 Failed asserting that two strings are equal. 10:55:59 --- Expected 10:55:59 +++ Actual 10:55:59 @@ @@ 10:55:59 -'updated' 10:55:59 +'newest' 10:55:59 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/tests/phpunit/Block/TopicListTest.php:58 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:147 10:55:59 **Expected results** * The test should pass, it passes in non generic at https://integration.wikimedia.org/ci/job/mwext-Thanks-testextension-hhvm/30/console So I doint think thanks is broken, I think echo and flow doint work correctly in thanks generic tests because doing an experimental check in those repos, passes the generic tests In those repos.

**Steps to reproduce** * Go to https://gerrit.wikimedia.org/r/#/c/274264/ * Type check experimental (Only if your whitelisted) Or you can just go to https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/4785/console **Actual results** * The test fails with this error **Expected results** * The test should pass, it passes in non generic at https://integration.wikimedia.org/ci/job/mwext-Thanks-testextension-hhvm/30/console So I doint think thanks is broken, I think echo and flow doint work correctly in thanks generic tests because doing an experimental check in those repos, passes the generic tests In those repos.

**Steps to reproduce** * Go to https://gerrit.wikimedia.org/r/#/c/274264/ * Type check experimental (Only if your whitelisted) Or you can just go to https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/4785/console **Actual results** * The test fails with this error 10:55:59 There was 1 error: 10:55:59 10:55:59 1) EchoEmailFormatterTest::testEmailFormatter 10:55:59 InvalidArgumentException: The icon is not registered 10:55:59 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/includes/formatters/NotificationFormatter.php:138 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/includes/EmailFormatter.php:175 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/includes/EmailFormatter.php:846 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/includes/EmailFormatter.php:733 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/includes/EmailFormatter.php:446 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/includes/EmailFormatter.php:87 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/tests/phpunit/EmailFormatterTest.php:53 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:147 10:55:59 10:55:59 -- 10:55:59 10:55:59 There was 1 failure: 10:55:59 10:55:59 1) Flow\Tests\Block\TopicListTest::testSortByOption 10:55:59 Default sortby now changed to updated 10:55:59 Failed asserting that two strings are equal. 10:55:59 --- Expected 10:55:59 +++ Actual 10:55:59 @@ @@ 10:55:59 -'updated' 10:55:59 +'newest' 10:55:59 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/tests/phpunit/Block/TopicListTest.php:58 10:55:59 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:147 10:55:59 **Expected results** * The test should pass, it passes in non generic at https://integration.wikimedia.org/ci/job/mwext-Thanks-testextension-hhvm/30/console So I doint think thanks is broken, I think echo and flow doint work correctly in thanks generic tests because doing an experimental check in those repos, passes the generic tests In those repos.