Change Details

ApiResult has a weird mess of functions that manipulate the internal data structure and data that manipulates an array that will later be added to the internal data structure, with some of the latter being dynamic for little good reason. And then clean up of uses of all the deprecated functions, and ideally some unit tests to make sure things are more-or-less working right as far as the BC transformations and so on. This is also going to enable (and might encompass) the cleanup of ApiFormatXml and the creation of "format=json2".

ApiResult has a weird mess of functions that manipulate the internal data structure and data that manipulates an array that will later be added to the internal data structure, with some of the latter being dynamic for little good reason. And then clean up of uses of all the deprecated functions, and ideally some unit tests to make sure things are more-or-less working right as far as the BC transformations and so on. Since it all needs changing anyway, at the same time let's do the "[[https://www.mediawiki.org/wiki/API/Architecture_work/Planning#Changes_to_XML_output_format|Make ApiFormatXml not throw errors when it's missing its metadata]]" and "[[https://www.mediawiki.org/wiki/API/Architecture_work/Planning#Changes_to_JSON_output_format|Create format=json2]]" items from the API work planning document.

ApiResult has a weird mess of functions that manipulate the internal data structure and data that manipulates an array that will later be added to the internal data structure, with some of the latter being dynamic for little good reason. And then clean up of uses of all the deprecated functions, and ideally some unit tests to make sure things are more-or-less working right as far as the BC transformations and so on. This is also going to enable (and might encompass) the cleanup of ApiFormatXml and the creation of "format=json2"Since it all needs changing anyway, at the same time let's do the "[[https://www.mediawiki.org/wiki/API/Architecture_work/Planning#Changes_to_XML_output_format|Make ApiFormatXml not throw errors when it's missing its metadata]]" and "[[https://www.mediawiki.org/wiki/API/Architecture_work/Planning#Changes_to_JSON_output_format|Create format=json2]]" items from the API work planning document.