Change Details

When adding a reference and reusing it further down an article, the VisualEditor used an already existing reference name as auto name, thus creating an error once the page was saved. [[ https://fr.wikipedia.org/w/index.php?title=Grenade_de_d%C3%A9sencerclement&diff=156613692&oldid=156605617 | Here's the diff ]]. <ref name=":0"> was already used in the article before this edit. Maybe T92432 could fix this too.

The visual editor can't see references produced by templates, so it's possible to create auto-numbered refs with names that conflict with those coming from a template. Example page: https://en.wikipedia.beta.wmflabs.org/wiki/User:Adamw/RefColonZeroFromTemplate Steps to reproduce: * Open the example page for editing. * Note that Cite "re-use" is disabled. * Add a manual, basic citation. * Now add a re-use of your basic citation. * Click the "edit source" button to see your changes. ==What happens== Your new ref will have the name ":0", despite this name colliding with the transcluded ref. ==What should have happened== The new refs should have been given the name ":1". =Technical notes= Currently, it seems that elements produced by a template don't show up in VE's `internalList` or other data structures which hold the page content. The templates probably show up under the "mw:Transclusion" portion of the list. Changing the data storage is the least-desirable solution. If possible, we want Cite to look into the DOM subtrees produced by transclusions and for those to be added to the list of refs for reuse, and to use the list of names to prevent collision.

When adding a reference and reusing it further down an articleThe visual editor can't see references produced by templates, so it's possible to create auto-numbered refs with names that conflict with those coming from a template. Example page: https://en.wikipedia.beta.wmflabs.org/wiki/User:Adamw/RefColonZeroFromTemplate Steps to reproduce: * Open the example page for editing. * Note that Cite "re-use" is disabled. * Add a manual, the VisualEditor used an already existing reference name as auto namebasic citation. * Now add a re-use of your basic citation. * Click the "edit source" button to see your changes. ==What happens== Your new ref will have the name ":0", thus creating an error once the page was saved.despite this name colliding with the transcluded ref. ==What should have happened== The new refs should have been given the name ":1". =Technical notes= [[ https://fr.wikipedia.org/w/index.php?title=Grenade_de_d%C3%A9sencerclement&diff=156613692&oldid=156605617 | Here's the diff ]]. <ref name=":0"> was already used in the article before this ediCurrently, it seems that elements produced by a template don't show up in VE's `internalList` or other data structures which hold the page content. The templates probably show up under the "mw:Transclusion" portion of the list. Maybe T92432 could fix this tooChanging the data storage is the least-desirable solution. If possible, we want Cite to look into the DOM subtrees produced by transclusions and for those to be added to the list of refs for reuse, and to use the list of names to prevent collision.