Use case:
1. On a page with a heading and some text. Put cursor at start of the paragraph after the heading.
2. Insert a template (ends up selecting it after finishing insertion)
3. "Insert" another template.
Expected:
A newA dialog pops up withshould appear with the ability to select adecide which template to insert etc.
Actual:
A dialog appears to edit the existing template appears.
selected transclusion that is already on the page.
After being genuinely confused for a minute I realised that the confusion came from the menu label being "Insert". A while back, the "Template" button was separate on the toolbar (or under "More" or "Tools" whatever it was). Back then, like still the case with lLinks and Text Style, it was more natural to assume it will edit and not create a template when a template is selected already because the button would be rendered "in an "active" (pressed -down" (again,) state (like for links and text style). like we do for links).However, However the menu has beenwas then relabelled to "Insert" and the Template button/items in the "Insert" menu-item no longer appears pressed down when a Template is do not have an "active" state to help correlate with the currently selected item on the page.
Perhaps we should make it render pressed down again.bring back the "active" state for the Insert menu items, for consistency with other buttons on the toolbar.
Or make it actually insert a new one at/before the current cursor position, Or make it actually insert a new one at the current cursor position (which means the template in case of a highlighted node) thus restricting users to only edit nodes for something in the "Insert" menu via the context menuwhich would mean that to edit a transclusion users then need to use the context menu instead.