Wow, I have to say I’m impressed with your efficiency and high quality output @Sharvaniharan @cooltey & @Dbrant. Image caption editing is already pretty solid in the Alpha (`2.7.50282-alpha-2019-06-11).
This is collected design feedback for the current state of “Suggested edits“ with the new image caption editing features. It has yet to be prioritized and distributed to the corresponding subtasks. An alternative approach would be to handle all of this as a **new task**, as @dbrant suggested in our 1:1 today. What do you think @Charlotte?
[ ] 1) Couldn’t publish once due to this error message below. The error appeared after translating an image caption from English to German (`File:AtomicRooster_Devils1998.jpg`).
{F29508918}
[ ] 2) Image loading on review screen is currently pretty slow, can we improve it (e.g. by delivering an image with lower resolution)? Or can we use the same loading indicator as for image publishing when there’s no image yet?
{F29479698}
[ ] 3) Image loading in bottom sheet is slow, can we improve it (e.g. by delivering an image with lower resolution)?
{F29480027}
[ ] 4) Edit button is currently hard to tap. It regularly hid all of the UI elements when I tried to tap the edit button. Can we increase touch target size to make this more convenient? Maybe some experimenting needed on a real device to make this work well.
{F29485654}
[ ] 5) ”An error occurred” message appears from time to time in the feed.
{F29482918}
[ ] 6) Update copy, according to [[ https://docs.google.com/spreadsheets/d/1t0IWXoSz7EYBS6LrQM5fV_qZ6paK_sFRjnCp9H7rEPo/edit#gid=0 | copy master doc ]]
{F29486490}
[ ] 7) Apply correct strings, [[ https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5ce57c571ba88b1def909e70 | see Zeplin ]] / [[ https://docs.google.com/spreadsheets/d/1t0IWXoSz7EYBS6LrQM5fV_qZ6paK_sFRjnCp9H7rEPo/edit#gid=0 | copy master ]]
{F29481431}
[ ] 8) Show unstructured description in bottom sheet as additional helper
{F29508702}
[ ] 9) Allow pulling up the bottom sheet. Currently it’s only possible to tap it when collapsed:
{F29479916}
[ ] 10) Make article description design consistent with image caption bottom sheet ([[ https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5ce562e57a89412a94b011f5 | see Zeplin ]])
{F29485495}
[ ] 11) Use correct “Add image caption” illustration here, [[ https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5ced4a9b1ba88b1defd7bb11 | check Zeplin for the correct one. ]]
{F29478454}
[ ] 12) Line height does not correlate with designs. It needs to be 1.5 (`24sp`) of the font-size (`16sp`). See [[ https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5ce57c5d156b3d1dd4af0c65 | Zeplin ]]. Plus, is there a padding on the right side or this just an unfortunate situation in this screenshot?
{F29478771}
[ ] 13) Output links in in black and without underline (text-decoration). Currently, it indicates that these are tappable which is not the case.
{F29479011}
[ ] 14) Font-size is different from designs. Needs to be `24sp`, [[ https://zpl.io/aX3DoOg | see Zeplin ]].
{F29479248}
[ ] 15) Gap is too wide/card is not high enough, needs to be `32dp`, [[ https://zpl.io/aX3DoOg | see Zeplin ]].
{F29479451}
[ ] 16) Button font-weight needs to be medium, it’s to thin currently. Plus, right padding needs to be `20sp` to balance out visual center.
{F29479585}
[ ] 17) Remove placeholder image from this screen. In general, try to not use that illustration/image anymore since we moved away from it (T218201)
{F29479745}
[ ] 18) I’m wondering if we could not cut the card here and make it overlap. Basically move the card to the front so it’s not cut off when dragged.
{F29482767}
[ ] 19) Always display this information below the unlocked tasks and remove the bottom part of the message/unlock criteria (Locked until you’ve made...) when users haven’t set multiple languages yet. Unlock criteria is only relevant once multiple languages have been set.
{F29483365}
[ ] 20) Opacity of icons varies, it needs to be `material_theme_de_emphasised_color` (#000 38% in light mode)
{F29483510}
[ ] 21) Increase bottom padding of extended FAB to `24sp` (it’s currently implemented according to the specs but it visually sits to low)
{F29483908}
[ ] 22) Adjust status bar color within feed to `suggestions_background_color` ([or can adapt it automatically based on `windowBackground`?](https://stackoverflow.com/a/24997241))
| {F29503151} | {F29503157} | {F29503167}
[ ] 23) Incorporate gradient to avoid cut off text in feed cards (see T224500)
{F29504570}
[ ] 24) Adapt dropdown background-color to `suggestions_background_color`
{F29505074}
[ ] 25) Adapt margins above and below images in bottom sheets, [according to specs on Zeplin](https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5cdac800fecb646826c6f35d)
{F29505273}
[ ] 26) Stretch separator lines to full width in bottom sheets
{F29505391}
[ ] 27) Image format should be 16:9 and can we deliver higher resolution images on tablets? It’s currently very pixelated.
{F29508018}
[ ] 28) Stretch bottom sheet to full-width on larger viewports.
{F29508571}
[ ] 29) I would have some input on how to improve the current card feed animation when going back since it feels a bit counterintuitive. Whoever takes on this task, can we have a quick chat [this video](https://www.dropbox.com/s/lg4sjcjy3gr01sj/animation.mov?dl=0) together? (yes I know, it’s mirrored 🙃).
[ ] 30) I realized that we’re still using the “legacy” interface to edit descriptions when coming from article pages. Can we update it to use [[ https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5ce57c59ff418a1e46d91e2d | the new UI ]]?
| {F29529623} | {F29529636}
[x] 31) Should we lower this number to 15 as well and remove “verified“ from the copy since we’re moving into the direction of immediate unlocking @Charlotte? (CC: Mholloway) [see T225635#5253643]
{F29486024}