Change Details

The ReadOnlyMode service currently requires LoadBalancer, which means migration to LBFactory/ConnectionProvider can't be completed in some cases. Example: UserGroupManager ```lang=php,name=UserGroupManager.php $this->loadBalancerFactory = $loadBalancerFactory; $loadBalancer = $loadBalancerFactory->getMainLB( $wikiId ); // Can't inject main ROM service, as this can be for a foreign wiki $this->readOnlyMode = new ReadOnlyMode( $configuredReadOnlyMode, $loadBalancer ); ``` Perhaps read-only status is widely used enough to justify one more method on ConnectionProvider, or alternatively add it only to LBFactory. It'd take `$domain` as argument, and figure out from there which LB to get it from internally (the implementation can move, but for now it'd likely come from LB).

The ReadOnlyMode service currently requires LoadBalancer, which means migration to LBFactory/ConnectionProvider can't be completed in some cases. Example: UserGroupManager ```lang=php,name=UserGroupManager.php $this->loadBalancerFactory = $loadBalancerFactory; $loadBalancer = $loadBalancerFactory->getMainLB( $wikiId ); // Can't inject main ROM service, as this can be for a foreign wiki $this->readOnlyMode = new ReadOnlyMode( $configuredReadOnlyMode, $loadBalancer ); ```

The ReadOnlyMode service currently requires LoadBalancer, which means migration to LBFactory/ConnectionProvider can't be completed in some cases. Example: UserGroupManager ```lang=php,name=UserGroupManager.php $this->loadBalancerFactory = $loadBalancerFactory; $loadBalancer = $loadBalancerFactory->getMainLB( $wikiId ); // Can't inject main ROM service, as this can be for a foreign wiki $this->readOnlyMode = new ReadOnlyMode( $configuredReadOnlyMode, $loadBalancer ); ``` Perhaps read-only status is widely used enough to justify one more method on ConnectionProvider, or alternatively add it only to LBFactory. It'd take `$domain` as argument, and figure out from there which LB to get it from internally (the implementation can move, but for now it'd likely come from LB).